mir/ovs
2
0
Fork 0
mirror of https://github.com/openvswitch/ovs synced 2025-08-31 06:15:47 +00:00
Code Issues Releases Wiki Activity

netdev-offload-dpdk: Fix flushing of a physdev.

Browse Source 
Vport's offloads are done on the tracked orig-in-port, but the flow itself
is associated in the vport's map.

Removing the physdev will flush all the ports that are on its map, but
not the ones on other netdevs' maps. Since flows take reference count on
both their vport and their physdev, the physdev still has references on.
Trying to remove it and re-add it fails with "already in use" error.

Fix it by flushing the physdev's offload flows in all related netdevs,
e.g. the netdev itself, or for physical devices, all vports.

Fixes: adbd4301a2 ("netdev-offload-dpdk: Use per-netdev offload metadata.")
Reported-by: wuxi_seu@163.com
Acked-by: Simon Horman <simon.horman@corigine.com>
Signed-off-by: Eli Britstein <elibr@nvidia.com>
Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
This commit is contained in:
Eli Britstein
2023-06-11 18:58:26 +03:00
committed by Ilya Maximets
parent b78427639f
commit 0aeb06e1fa
1 changed files with 30 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

35
lib/netdev-offload-dpdk.c
View File

@@ -2537,15 +2537,15 @@ out:
return ret;
}
static int
netdev_offload_dpdk_flow_flush(struct netdev *netdev)
static void
flush_netdev_flows_in_related(struct netdev *netdev, struct netdev *related)
{
struct cmap *map = offload_data_map(netdev);
struct ufid_to_rte_flow_data *data;
unsigned int tid = netdev_offload_thread_id();
struct cmap *map = offload_data_map(related);
struct ufid_to_rte_flow_data *data;
if (!map) {
return -1;
return;
}
CMAP_FOR_EACH (data, node, map) {
@@ -2556,6 +2556,31 @@ netdev_offload_dpdk_flow_flush(struct netdev *netdev)
netdev_offload_dpdk_flow_destroy(data);
}
}
}
static bool
flush_in_vport_cb(struct netdev *vport,
odp_port_t odp_port OVS_UNUSED,
void *aux)
{
struct netdev *netdev = aux;
/* Only vports are related to physical devices. */
if (netdev_vport_is_vport_class(vport->netdev_class)) {
flush_netdev_flows_in_related(netdev, vport);
}
return false;
}
static int
netdev_offload_dpdk_flow_flush(struct netdev *netdev)
{
flush_netdev_flows_in_related(netdev, netdev);
if (!netdev_vport_is_vport_class(netdev->netdev_class)) {
netdev_ports_traverse(netdev->dpif_type, flush_in_vport_cb, netdev);
}
return 0;
}