mir/ovs
2
0
Fork 0
mirror of https://github.com/openvswitch/ovs synced 2025-09-03 07:45:30 +00:00
Code Issues Releases Wiki Activity

ofp-actions: Add hex dump of bad actions to log message on error.

Browse Source 
This should make debugging easier in such cases.

Bug #12460.
Reported-by: Natasha Gude <natasha@nicira.com>
Reported-by: James Schmidt <jschmidt@nicira.com>
Signed-off-by: Ben Pfaff <blp@nicira.com>
This commit is contained in:
Ben Pfaff
2012-07-09 14:21:00 -07:00
parent 5cb2356b59
commit 0c449c5683
1 changed files with 9 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
lib/ofp-actions.c
View File

@@ -450,8 +450,15 @@ ofpacts_from_openflow10(const union ofp_action *in, size_t n_in,
} }
} }
if (left) { if (left) {
VLOG_WARN_RL(&rl, "bad action format at offset %zu", if (!VLOG_DROP_WARN(&rl)) {
(n_in - left) * sizeof *a); struct ds s;
ds_init(&s);
ds_put_hex_dump(&s, in, n_in * sizeof *a, 0, false);
VLOG_WARN("bad action format at offset %#x:\n%s",
(n_in - left) * sizeof *a, ds_cstr(&s));
ds_destroy(&s);
}
return OFPERR_OFPBAC_BAD_LEN; return OFPERR_OFPBAC_BAD_LEN;
} }