mir/ovs
2
0
Fork 0
mirror of https://github.com/openvswitch/ovs synced 2025-08-31 14:25:26 +00:00
Code Issues Releases Wiki Activity

dpif-netdev: Use PMD context to get the port for HW miss recovery.

Browse Source 
Last RX queue, from which the packet got received, is already stored
in the PMD context.  So, we can get the netdev from it without the
expensive hash map lookup.

In my V2V testing this patch improves performance in case HW offload
and experimental APIs are enabled by about 3%.  That narrows down the
performance difference with the case with experimental API disabled
to about 0.5%, which is way within a margin of error for that setup.

Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
Acked-by: Eli Britstein <elibr@nvidia.com>
Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
This commit is contained in:
Ilya Maximets
2021-12-03 22:12:15 +01:00
parent 17346b3899
commit 20a4f546f7
3 changed files with 8 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/dpif-netdev-avx512.c
View File

@@ -186,7 +186,7 @@ dp_netdev_input_outer_avx512(struct dp_netdev_pmd_thread *pmd,
/* Check for a partial hardware offload match. */
if (hwol_enabled) {
if (OVS_UNLIKELY(dp_netdev_hw_flow(pmd, in_port, packet, &f))) {
if (OVS_UNLIKELY(dp_netdev_hw_flow(pmd, packet, &f))) {
/* Packet restoration failed and it was dropped, do not
* continue processing. */
continue;

1
lib/dpif-netdev-private.h
View File

@@ -46,7 +46,6 @@ dp_netdev_batch_execute(struct dp_netdev_pmd_thread *pmd,
int
dp_netdev_hw_flow(const struct dp_netdev_pmd_thread *pmd,
odp_port_t port_no,
struct dp_packet *packet,
struct dp_netdev_flow **flow);

14
lib/dpif-netdev.c
View File

@@ -7322,29 +7322,23 @@ smc_lookup_single(struct dp_netdev_pmd_thread *pmd,
return NULL;
}
static struct tx_port * pmd_send_port_cache_lookup(
const struct dp_netdev_pmd_thread *pmd, odp_port_t port_no);
inline int
dp_netdev_hw_flow(const struct dp_netdev_pmd_thread *pmd,
odp_port_t port_no OVS_UNUSED,
struct dp_packet *packet,
struct dp_netdev_flow **flow)
{
struct tx_port *p OVS_UNUSED;
uint32_t mark;
#ifdef ALLOW_EXPERIMENTAL_API /* Packet restoration API required. */
/* Restore the packet if HW processing was terminated before completion. */
p = pmd_send_port_cache_lookup(pmd, port_no);
if (OVS_LIKELY(p)) {
int err = netdev_hw_miss_packet_recover(p->port->netdev, packet);
struct dp_netdev_rxq *rxq = pmd->ctx.last_rxq;
int err;
err = netdev_hw_miss_packet_recover(rxq->port->netdev, packet);
if (err && err != EOPNOTSUPP) {
COVERAGE_INC(datapath_drop_hw_miss_recover);
return -1;
}
}
#endif
/* If no mark, no flow to find. */
@@ -7420,7 +7414,7 @@ dfc_processing(struct dp_netdev_pmd_thread *pmd,
}
if (netdev_flow_api && recirc_depth == 0) {
if (OVS_UNLIKELY(dp_netdev_hw_flow(pmd, port_no, packet, &flow))) {
if (OVS_UNLIKELY(dp_netdev_hw_flow(pmd, packet, &flow))) {
/* Packet restoration failed and it was dropped, do not
* continue processing.
*/