mir/ovs
2
0
Fork 0
mirror of https://github.com/openvswitch/ovs synced 2025-08-31 06:15:47 +00:00
Code Issues Releases Wiki Activity

Log anything that could prevent a daemon from starting.

Browse Source 
If a daemon doesn't start, we need to know why.  Being able to
consistently consult the log to find out is helpful.
This commit is contained in:
Ben Pfaff
2011-03-31 16:23:50 -07:00
parent fcaddd4dd1
commit 279c9e0308
20 changed files with 171 additions and 105 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
lib/daemon.c
View File

@@ -239,9 +239,7 @@ fork_and_wait_for_startup(int *fdp)
int fds[2];
pid_t pid;
if (pipe(fds) < 0) {
ovs_fatal(errno, "pipe failed");
}
xpipe(fds);
pid = fork();
if (pid > 0) {
@@ -266,7 +264,8 @@ fork_and_wait_for_startup(int *fdp)
exit(WEXITSTATUS(status));
}
ovs_fatal(errno, "fork child failed to signal startup");
VLOG_FATAL("fork child failed to signal startup (%s)",
strerror(errno));
}
close(fds[0]);
*fdp = -1;
@@ -277,7 +276,7 @@ fork_and_wait_for_startup(int *fdp)
lockfile_postfork();
*fdp = fds[1];
} else {
ovs_fatal(errno, "could not fork");
VLOG_FATAL("fork failed (%s)", strerror(errno));
}
return pid;
@@ -292,7 +291,7 @@ fork_notify_startup(int fd)
error = write_fully(fd, "", 1, &bytes_written);
if (error) {
ovs_fatal(error, "could not write to pipe");
VLOG_FATAL("pipe write failed (%s)", strerror(error));
}
close(fd);
@@ -346,7 +345,7 @@ monitor_daemon(pid_t daemon_pid)
} while (retval == -1 && errno == EINTR);
if (retval == -1) {
ovs_fatal(errno, "waitpid failed");
VLOG_FATAL("waitpid failed (%s)", strerror(errno));
} else if (retval == daemon_pid) {
char *s = process_status_msg(status);
if (should_restart(status)) {