mir/ovs
2
0
Fork 0
mirror of https://github.com/openvswitch/ovs synced 2025-08-22 09:58:01 +00:00
Code Issues Releases Wiki Activity

raft: Fix resource leak from ignored ovsdb_log_write_and_free() error.

Browse Source 
The Raft codebase includes calls to ovsdb_log_write_and_free() that
are incorrectly wrapped in ignore(). This causes potential error
resources to be leaked.

These calls should be wrapped in ovsdb_error_destroy() instead, to
ensure that any returned error objects are properly freed and do not
result in memory leaks.

Fixes: 1b1d2e6daa56 ("ovsdb: Introduce experimental support for clustered databases.")
Acked-by: Mike Pattrick <mkp@redhat.com>
Acked-by: Aaron Conole <aconole@redhat.com>
Signed-off-by: Eelco Chaudron <echaudro@redhat.com>
This commit is contained in:
Eelco Chaudron 2025-06-05 16:51:29 +02:00
parent b90304bfe7
commit 2c634482f2
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
ovsdb/raft.c
View File

@ -1261,7 +1261,8 @@ raft_record_note(struct raft *raft, const char *note,
.comment = comment, .comment = comment,
.note = CONST_CAST(char *, note), .note = CONST_CAST(char *, note),
}; };
ignore(ovsdb_log_write_and_free(raft->log, raft_record_to_json(&r))); ovsdb_error_destroy(
ovsdb_log_write_and_free(raft->log, raft_record_to_json(&r)));
free(comment); free(comment);
} }
@ -2996,7 +2997,8 @@ raft_become_leader(struct raft *raft)
.term = raft->term, .term = raft->term,
.sid = raft->sid, .sid = raft->sid,
}; };
ignore(ovsdb_log_write_and_free(raft->log, raft_record_to_json(&r))); ovsdb_error_destroy(
ovsdb_log_write_and_free(raft->log, raft_record_to_json(&r)));
/* Initiate a no-op commit. Otherwise we might never find out what's in /* Initiate a no-op commit. Otherwise we might never find out what's in
* the log. See section 6.4 item 1: * the log. See section 6.4 item 1:
@ -3224,7 +3226,8 @@ raft_update_commit_index(struct raft *raft, uint64_t new_commit_index)
.type = RAFT_REC_COMMIT_INDEX, .type = RAFT_REC_COMMIT_INDEX,
.commit_index = raft->commit_index, .commit_index = raft->commit_index,
}; };
ignore(ovsdb_log_write_and_free(raft->log, raft_record_to_json(&r))); ovsdb_error_destroy(
ovsdb_log_write_and_free(raft->log, raft_record_to_json(&r)));
return true; return true;
} }
@ -3412,7 +3415,8 @@ raft_update_leader(struct raft *raft, const struct uuid *sid)
.term = raft->term, .term = raft->term,
.sid = *sid, .sid = *sid,
}; };
ignore(ovsdb_log_write_and_free(raft->log, raft_record_to_json(&r))); ovsdb_error_destroy
(ovsdb_log_write_and_free(raft->log, raft_record_to_json(&r)));
} }
if (raft->role == RAFT_CANDIDATE) { if (raft->role == RAFT_CANDIDATE) {
/* Section 3.4: While waiting for votes, a candidate may /* Section 3.4: While waiting for votes, a candidate may