mir/ovs
2
0
Fork 0
mirror of https://github.com/openvswitch/ovs synced 2025-09-05 08:45:23 +00:00
Code Issues Releases Wiki Activity

util: Pass 128-bit arguments directly instead of using pointers.

Browse Source 
Commit f2d105b5 (ofproto-dpif-xlate: xlate ct_{mark, label} correctly.)
introduced the ovs_u128_and() function.  It directly takes ovs_u128
values as arguments instead of pointers to them.  As this is a bit more
direct way to deal with 128-bit values, modify the other utility
functions to do the same.

Signed-off-by: Justin Pettit <jpettit@ovn.org>
Acked-by: Joe Stringer <joe@ovn.org>
This commit is contained in:
Justin Pettit
2016-05-03 18:20:51 -07:00
parent 20322d4b6e
commit 2ff8484bbf
12 changed files with 29 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
lib/util.h
View File

@@ -392,37 +392,37 @@ void bitwise_toggle_bit(void *dst, unsigned int len, unsigned int ofs);
/* Returns non-zero if the parameters have equal value. */
static inline int
ovs_u128_equals(const ovs_u128 *a, const ovs_u128 *b)
ovs_u128_equals(const ovs_u128 a, const ovs_u128 b)
{
return (a->u64.hi == b->u64.hi) && (a->u64.lo == b->u64.lo);
return (a.u64.hi == b.u64.hi) && (a.u64.lo == b.u64.lo);
}
/* Returns true if 'val' is 0. */
static inline bool
ovs_u128_is_zero(const ovs_u128 *val)
ovs_u128_is_zero(const ovs_u128 val)
{
return !(val->u64.hi || val->u64.lo);
return !(val.u64.hi || val.u64.lo);
}
/* Returns true if 'val' is all ones. */
static inline bool
ovs_u128_is_ones(const ovs_u128 *val)
ovs_u128_is_ones(const ovs_u128 val)
{
return ovs_u128_equals(val, &OVS_U128_MAX);
return ovs_u128_equals(val, OVS_U128_MAX);
}
/* Returns non-zero if the parameters have equal value. */
static inline int
ovs_be128_equals(const ovs_be128 *a, const ovs_be128 *b)
ovs_be128_equals(const ovs_be128 a, const ovs_be128 b)
{
return (a->be64.hi == b->be64.hi) && (a->be64.lo == b->be64.lo);
return (a.be64.hi == b.be64.hi) && (a.be64.lo == b.be64.lo);
}
/* Returns true if 'val' is 0. */
static inline bool
ovs_be128_is_zero(const ovs_be128 *val)
ovs_be128_is_zero(const ovs_be128 val)
{
return !(val->be64.hi || val->be64.lo);
return !(val.be64.hi || val.be64.lo);
}
static inline ovs_u128