mir/ovs
2
0
Fork 0
mirror of https://github.com/openvswitch/ovs synced 2025-08-31 14:25:26 +00:00
Code Issues Releases Wiki Activity

ofp-util: Improve log message for bad OpenFlow action length.

Browse Source 
First, this is an important message since it indicates a bug in the
controller, so log it at warning level instead of debug level--we want to
know about it.

Second, properly byteswap the action type.

Third, use the correct PRIu16 format specified for a uint16_t.
This commit is contained in:
Ben Pfaff
2010-12-23 10:36:02 -08:00
parent 01ca1bfcbd
commit 35c4693ab8
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
lib/ofp-util.c
View File

@@ -1637,9 +1637,9 @@ check_action_exact_len(const union ofp_action *a, unsigned int len,
unsigned int required_len)
{
if (len != required_len) {
VLOG_DBG_RL(&bad_ofmsg_rl,
"action %u has invalid length %"PRIu16" (must be %u)\n",
a->type, ntohs(a->header.len), required_len);
VLOG_WARN_RL(&bad_ofmsg_rl, "action %"PRIu16" has invalid length "
"%"PRIu16" (must be %u)\n",
ntohs(a->type), ntohs(a->header.len), required_len);
return ofp_mkerr(OFPET_BAD_ACTION, OFPBAC_BAD_LEN);
}
return 0;