mir/ovs
2
0
Fork 0
mirror of https://github.com/openvswitch/ovs synced 2025-09-03 15:55:19 +00:00
Code Issues Releases Wiki Activity

python/ovs/socket_util: don't use Exception, but ValueError

Browse Source 
67656b9ff2
used Exception, but it should be more specific error.
Use ValueError instread of Exception.

Suggested-by: Reid Price <reid@nicira.com>
Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>
Signed-off-by: Ben Pfaff <blp@nicira.com>
This commit is contained in:
Isaku Yamahata
2012-10-16 06:57:27 +09:00
committed by Ben Pfaff
parent 93ea780907
commit 378cc7f112
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
python/ovs/socket_util.py
View File

@@ -88,13 +88,13 @@ def inet_parse_active(target, default_port):
address = target.split(":") address = target.split(":")
host_name = address[0] host_name = address[0]
if not host_name: if not host_name:
raise Exception("%s: bad peer name format" % target) raise ValueError("%s: bad peer name format" % target)
if len(address) >= 2: if len(address) >= 2:
port = int(address[1]) port = int(address[1])
elif default_port: elif default_port:
port = default_port port = default_port
else: else:
raise Exception("%s: port number must be specified" % target) raise ValueError("%s: port number must be specified" % target)
return (host_name, port) return (host_name, port)
@@ -187,6 +187,6 @@ def set_nonblocking(sock):
def set_dscp(sock, dscp): def set_dscp(sock, dscp):
if dscp > 63: if dscp > 63:
raise Exception("Invalid dscp %d" % dscp) raise ValueError("Invalid dscp %d" % dscp)
val = dscp << 2 val = dscp << 2
sock.setsockopt(socket.IPPROTO_IP, socket.IP_TOS, val) sock.setsockopt(socket.IPPROTO_IP, socket.IP_TOS, val)