mir/ovs
2
0
Fork 0
mirror of https://github.com/openvswitch/ovs synced 2025-09-01 23:05:29 +00:00
Code Issues Releases Wiki Activity

conntrack: Add coverage count for l4csum error.

Browse Source 
Add a coverage counter when userspace conntrack receives a packet
with invalid l4 checksum.  When using veth for testing, users
often forget to turn off the tx offload on the other side of the
namespace, causing l4 checksum not calculated in packet header,
and at conntrack, return invalid conntrack state.

Suggested-by: Yi-Hung Wei <yihung.wei@gmail.com>
Signed-off-by: William Tu <u9012063@gmail.com>
Acked-by: Yi-Hung Wei <yihung.wei@gmail.com>
This commit is contained in:
William Tu
2020-04-16 12:54:53 -07:00
parent 5bb068a772
commit 38c69ccf8e
1 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
lib/conntrack.c
View File

@@ -44,6 +44,7 @@ VLOG_DEFINE_THIS_MODULE(conntrack);
COVERAGE_DEFINE(conntrack_full); COVERAGE_DEFINE(conntrack_full);
COVERAGE_DEFINE(conntrack_long_cleanup); COVERAGE_DEFINE(conntrack_long_cleanup);
COVERAGE_DEFINE(conntrack_l4csum_err);
struct conn_lookup_ctx { struct conn_lookup_ctx {
struct conn_key key; struct conn_key key;
@@ -1661,6 +1662,7 @@ checksum_valid(const struct conn_key *key, const void *data, size_t size,
} else if (key->dl_type == htons(ETH_TYPE_IPV6)) { } else if (key->dl_type == htons(ETH_TYPE_IPV6)) {
return packet_csum_upperlayer6(l3, data, key->nw_proto, size) == 0; return packet_csum_upperlayer6(l3, data, key->nw_proto, size) == 0;
} else { } else {
COVERAGE_INC(conntrack_l4csum_err);
return false; return false;
} }
} }
@@ -1704,7 +1706,12 @@ check_l4_udp(const struct conn_key *key, const void *data, size_t size,
static inline bool static inline bool
check_l4_icmp(const void *data, size_t size, bool validate_checksum) check_l4_icmp(const void *data, size_t size, bool validate_checksum)
{ {
return validate_checksum ? csum(data, size) == 0 : true; if (validate_checksum && csum(data, size) != 0) {
COVERAGE_INC(conntrack_l4csum_err);
return false;
} else {
return true;
}
} }
static inline bool static inline bool