2
0
mirror of https://github.com/openvswitch/ovs synced 2025-08-22 01:51:26 +00:00

ovs-macros.at: Correctly delete iptables rule on_exit.

Currently, at every call of IPTABLES_ACCEPT() an iptables rule gets
added. Such rule is supposed to be removed on exit, but the current
syntax for deleting the rule is incorrect, resulting in a leftover
rule after execution.

Fix it by correcting the deletion command.

Fixes: 5e06e7ac99dc ("tests: Refactor the iptables accept rule.")
Reviewed-by: Aaron Conole <aconole@redhat.com>
Acked-by: Simon Horman <horms@ovn.org>
Acked-by: Eelco Chaudron <echaudro@redhat.com>
Signed-off-by: Paolo Valerio <pvalerio@redhat.com>
Signed-off-by: Aaron Conole <aconole@redhat.com>
This commit is contained in:
Paolo Valerio 2024-10-07 17:54:25 +02:00 committed by Aaron Conole
parent 60917c822d
commit 4459918386

View File

@ -365,4 +365,4 @@ dnl to reject input traffic from bridges such as br-underlay.
dnl Add a rule to always accept the traffic.
m4_define([IPTABLES_ACCEPT],
[AT_CHECK([iptables -I INPUT 1 -i $1 -j ACCEPT])
on_exit 'iptables -D INPUT 1 -i $1'])
on_exit 'iptables -D INPUT 1'])