mir/ovs
2
0
Fork 0
mirror of https://github.com/openvswitch/ovs synced 2025-08-30 05:47:55 +00:00
Code Issues Releases Wiki Activity

bond: Warn of imminent default bond_mode change.

Browse Source 
Post version 1.4.*, we are planning to change the default bond_mode
from balance-slb to active-backup.  This commit warns users of the
change so that they can prepare.

Signed-off-by: Ethan Jackson <ethan@nicira.com>
This commit is contained in:
Ethan Jackson 2011-12-15 13:39:38 -08:00
parent d2007e456a
commit 4c57c3bcfc
2 changed files with 22 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
NEWS
View File

@ -29,6 +29,13 @@ v1.4.0 - xx xxx xxxx
and connectivity issues. This tool currently is not included in RH or and connectivity issues. This tool currently is not included in RH or
Xen packages. Xen packages.
- RHEL packaging now supports integration with Red Hat network scripts. - RHEL packaging now supports integration with Red Hat network scripts.
- bonding:
- Post 1.4.*, OVS will be changing the default bond mode from balance-slb
to active-backup. SLB bonds carry significant risks with them
(documented vswitchd/INTERNALS) which we want to prevent unsuspecting
users from running into. Users are advised to update any scripts or
configuration which may be negatively impacted by explicitly setting
the bond mode which they want to use.
v1.3.0 - xx xxx xxxx v1.3.0 - xx xxx xxxx

20
vswitchd/bridge.c
View File

@ -2740,11 +2740,21 @@ port_configure_bond(struct port *port, struct bond_settings *s,
s->name = port->name; s->name = port->name;
s->balance = BM_SLB; s->balance = BM_SLB;
if (port->cfg->bond_mode if (port->cfg->bond_mode) {
&& !bond_mode_from_string(&s->balance, port->cfg->bond_mode)) { if (!bond_mode_from_string(&s->balance, port->cfg->bond_mode)) {
VLOG_WARN("port %s: unknown bond_mode %s, defaulting to %s", VLOG_WARN("port %s: unknown bond_mode %s, defaulting to %s",
port->name, port->cfg->bond_mode, port->name, port->cfg->bond_mode,
bond_mode_to_string(s->balance)); bond_mode_to_string(s->balance));
}
} else {
static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 1);
/* XXX: Post version 1.4.*, change the default bond_mode to
* active-backup. Until then, warn that the change is imminent. */
VLOG_WARN_RL(&rl, "port %s: Using the default bond_mode %s. Note that"
" in future versions, the default bond_mode is expected"
" to change to active-backup", port->name,
bond_mode_to_string(s->balance));
} }
if (s->balance == BM_SLB && port->bridge->cfg->n_flood_vlans) { if (s->balance == BM_SLB && port->bridge->cfg->n_flood_vlans) {
VLOG_WARN("port %s: SLB bonds are incompatible with flood_vlans, " VLOG_WARN("port %s: SLB bonds are incompatible with flood_vlans, "