mir/ovs
2
0
Fork 0
mirror of https://github.com/openvswitch/ovs synced 2025-08-22 01:51:26 +00:00
Code Issues Releases Wiki Activity

bond: Change default bond_mode to active-backup.

Browse Source 
As promised, post version 1.4 the default bond_mode is changing to
active-backup with this commit.

Signed-off-by: Ethan Jackson <ethan@nicira.com>
This commit is contained in:
Ethan Jackson 2012-01-11 17:23:38 -08:00
parent 4592d0e2fb
commit 4df08875a5
4 changed files with 10 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
NEWS
View File

@ -1,5 +1,9 @@
post-v1.5.0
------------------------
- bonding
- The default bond_mode changed from SLB to active-backup, to protect
unsuspecting users from the significant risks of SLB bonds (which are
documented in vswitchd/INTERNALS).
v1.5.0 - xx xxx xxxx

1
tests/lacp.at
View File

@ -40,7 +40,6 @@ AT_SETUP([lacp - multi port config])
OVS_VSWITCHD_START([dnl
add-bond br0 bond p1 p2 --\
set Port bond lacp=active \
bond_mode=active-backup \
other_config:lacp-time="fast" \
other_config:lacp-system-id=11:22:33:44:55:66 \
other_config:lacp-system-priority=54321 --\

10
vswitchd/bridge.c
View File

@ -2746,7 +2746,7 @@ port_configure_bond(struct port *port, struct bond_settings *s,
size_t i;
s->name = port->name;
s->balance = BM_SLB;
s->balance = BM_AB;
if (port->cfg->bond_mode) {
if (!bond_mode_from_string(&s->balance, port->cfg->bond_mode)) {
VLOG_WARN("port %s: unknown bond_mode %s, defaulting to %s",
@ -2756,11 +2756,11 @@ port_configure_bond(struct port *port, struct bond_settings *s,
} else {
static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 1);
/* XXX: Post version 1.4.*, change the default bond_mode to
* active-backup. Until then, warn that the change is imminent. */
/* XXX: Post version 1.5.*, the default bond_mode changed from SLB to
* active-backup. At some point we should remove this warning. */
VLOG_WARN_RL(&rl, "port %s: Using the default bond_mode %s. Note that"
" in future versions, the default bond_mode is expected"
" to change to active-backup", port->name,
" in previous versions, the default bond_mode was"
" balance-slb", port->name,
bond_mode_to_string(s->balance));
}
if (s->balance == BM_SLB && port->bridge->cfg->n_flood_vlans) {

2
vswitchd/vswitch.xml
View File

@ -790,7 +790,7 @@
<column name="bond_mode">
<p>The type of bonding used for a bonded port. Defaults to
<code>balance-slb</code> if unset.
<code>active-backup</code> if unset.
</p>
</column>