mir/ovs
2
0
Fork 0
mirror of https://github.com/openvswitch/ovs synced 2025-09-04 00:05:15 +00:00
Code Issues Releases Wiki Activity

ovsdb-idl: Fix double-remove in ovsdb_idl_condition_reset().

Browse Source 
Both ovsdb_idl_condition_reset() and ovsdb_idl_clause_free() call
ovs_list_remove() on the clause's 'node' member, but it should only be
called once.

Signed-off-by: Ben Pfaff <blp@ovn.org>
Acked-by: Andy Zhou <azhou@ovn.org>
This commit is contained in:
Ben Pfaff
2016-08-13 17:37:54 -07:00
parent 9aef3c1ba5
commit 5f3a484532
1 changed files with 0 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
lib/ovsdb-idl.c
View File

@@ -753,7 +753,6 @@ ovsdb_idl_condition_reset(struct ovsdb_idl *idl,
struct ovsdb_idl_table *table = ovsdb_idl_table_from_class(idl, tc); struct ovsdb_idl_table *table = ovsdb_idl_table_from_class(idl, tc);
LIST_FOR_EACH_SAFE (c, next, node, &table->condition.clauses) { LIST_FOR_EACH_SAFE (c, next, node, &table->condition.clauses) {
ovs_list_remove(&c->node);
ovsdb_idl_clause_free(c); ovsdb_idl_clause_free(c);
} }
idl->cond_changed = table->cond_changed = true; idl->cond_changed = table->cond_changed = true;