mir/ovs
2
0
Fork 0
mirror of https://github.com/openvswitch/ovs synced 2025-08-31 06:15:47 +00:00
Code Issues Releases Wiki Activity

lib/dpif-linux: Use relaxed atomics for 'dump->status'.

Browse Source 
'dump->status' does not syncronize the state of any other variable, so
we can use relaxed atomics on it.

Signed-off-by: Jarno Rajahalme <jrajahalme@nicira.com>
Acked-by: Ben Pfaff <blp@nicira.com>
This commit is contained in:
Jarno Rajahalme
2014-08-29 10:34:52 -07:00
parent 7e2b277bed
commit 7424fc4464
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
lib/dpif-linux.c
View File

@@ -1150,7 +1150,8 @@ dpif_linux_flow_dump_destroy(struct dpif_flow_dump *dump_)
unsigned int nl_status = nl_dump_done(&dump->nl_dump);
int dump_status;
atomic_read(&dump->status, &dump_status);
/* No other thread has access to 'dump' at this point. */
atomic_read_relaxed(&dump->status, &dump_status);
free(dump);
return dump_status ? dump_status : nl_status;
}
@@ -1237,7 +1238,7 @@ dpif_linux_flow_dump_next(struct dpif_flow_dump_thread *thread_,
/* Convert the flow to our output format. */
error = dpif_linux_flow_from_ofpbuf(&linux_flow, &nl_flow);
if (error) {
atomic_store(&dump->status, error);
atomic_store_relaxed(&dump->status, error);
break;
}
@@ -1256,7 +1257,7 @@ dpif_linux_flow_dump_next(struct dpif_flow_dump_thread *thread_,
} else if (error) {
VLOG_WARN("error fetching dumped flow: %s",
ovs_strerror(error));
atomic_store(&dump->status, error);
atomic_store_relaxed(&dump->status, error);
break;
}