2
0
mirror of https://github.com/openvswitch/ovs synced 2025-08-31 06:15:47 +00:00

dpif-netdev: Use packet key to parse TCP flags.

The flow that created the netdev_flow might have wildcarded TCP flags,
or it may not be a TCP flow at all.  Fix this by using the freshly
extracted flow key to parse TCP flags.

Signed-off-by: Jarno Rajahalme <jrajahalme@nicira.com>
Signed-off-by: Ben Pfaff <blp@nicira.com>
This commit is contained in:
Jarno Rajahalme
2014-03-19 16:13:32 -07:00
parent 03fbdf8d9c
commit 855dd13c9a

View File

@@ -1710,9 +1710,10 @@ dp_netdev_flow_stats_new_cb(void)
static void
dp_netdev_flow_used(struct dp_netdev_flow *netdev_flow,
const struct ofpbuf *packet)
const struct ofpbuf *packet,
const struct flow *key)
{
uint16_t tcp_flags = packet_get_tcp_flags(packet, &netdev_flow->flow);
uint16_t tcp_flags = packet_get_tcp_flags(packet, key);
long long int now = time_msec();
struct dp_netdev_flow_stats *bucket;
@@ -1762,7 +1763,7 @@ dp_netdev_port_input(struct dp_netdev *dp, struct ofpbuf *packet,
if (netdev_flow) {
struct dp_netdev_actions *actions;
dp_netdev_flow_used(netdev_flow, packet);
dp_netdev_flow_used(netdev_flow, packet, &key);
actions = dp_netdev_flow_get_actions(netdev_flow);
dp_netdev_execute_actions(dp, &key, packet, md,