mir/ovs
2
0
Fork 0
mirror of https://github.com/openvswitch/ovs synced 2025-09-02 07:15:17 +00:00
Code Issues Releases Wiki Activity

netdev-vport: Disable Path MTU Discovery by default

Browse Source 
In near future we will switch to the flow-based tunneling and drop path
MTU discovery support. This patch prepares for that by changing the default
PMTUD value from 'enabled' to 'disabled'.

Signed-off-by: Ansis Atteka <aatteka@nicira.com>
This commit is contained in:
Ansis Atteka
2012-10-22 10:04:28 +03:00
parent 3e34fbdd62
commit 85b53b3110
3 changed files with 7 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
NEWS
View File

@@ -32,6 +32,7 @@ v1.9.0 - xx xxx xxxx
are true, but because we do not know of any users for this are true, but because we do not know of any users for this
feature it seems better on balance to remove it. (The ovs-pki-cgi feature it seems better on balance to remove it. (The ovs-pki-cgi
program was not included in distribution packaging.) program was not included in distribution packaging.)
- Tunnel Path MTU Discovery default value was set to 'disabled'.
- ovsdb-server now enforces the immutability of immutable columns. This - ovsdb-server now enforces the immutability of immutable columns. This
was not enforced in earlier versions due to an oversight. was not enforced in earlier versions due to an oversight.
- New support for a nonstandard form of GRE that supports a 64-bit key. - New support for a nonstandard form of GRE that supports a 64-bit key.

10
lib/netdev-vport.c
View File

@@ -590,7 +590,7 @@ parse_tunnel_config(const char *name, const char *type,
ovs_be32 saddr = htonl(0); ovs_be32 saddr = htonl(0);
uint32_t flags; uint32_t flags;
flags = TNL_F_DF_DEFAULT | TNL_F_PMTUD | TNL_F_HDR_CACHE; flags = TNL_F_DF_DEFAULT | TNL_F_HDR_CACHE;
if (!strcmp(type, "gre") || !strcmp(type, "gre64")) { if (!strcmp(type, "gre") || !strcmp(type, "gre64")) {
is_gre = true; is_gre = true;
} else if (!strcmp(type, "ipsec_gre") || !strcmp(type, "ipsec_gre64")) { } else if (!strcmp(type, "ipsec_gre") || !strcmp(type, "ipsec_gre64")) {
@@ -647,8 +647,8 @@ parse_tunnel_config(const char *name, const char *type,
flags &= ~TNL_F_DF_DEFAULT; flags &= ~TNL_F_DF_DEFAULT;
} }
} else if (!strcmp(node->key, "pmtud")) { } else if (!strcmp(node->key, "pmtud")) {
if (!strcmp(node->value, "false")) { if (!strcmp(node->value, "true")) {
flags &= ~TNL_F_PMTUD; flags |= TNL_F_PMTUD;
} }
} else if (!strcmp(node->key, "header_cache")) { } else if (!strcmp(node->key, "header_cache")) {
if (!strcmp(node->value, "false")) { if (!strcmp(node->value, "false")) {
@@ -844,8 +844,8 @@ unparse_tunnel_config(const char *name OVS_UNUSED, const char *type OVS_UNUSED,
if (!(flags & TNL_F_DF_DEFAULT)) { if (!(flags & TNL_F_DF_DEFAULT)) {
smap_add(args, "df_default", "false"); smap_add(args, "df_default", "false");
} }
if (!(flags & TNL_F_PMTUD)) { if (flags & TNL_F_PMTUD) {
smap_add(args, "pmtud", "false"); smap_add(args, "pmtud", "true");
} }
return 0; return 0;

2
vswitchd/vswitch.xml
View File

@@ -1366,7 +1366,7 @@
of the tunnel headers. Note that this option causes behavior that is of the tunnel headers. Note that this option causes behavior that is
typically reserved for routers and therefore is not entirely in typically reserved for routers and therefore is not entirely in
compliance with the IEEE 802.1D specification for bridges. Default is compliance with the IEEE 802.1D specification for bridges. Default is
enabled; set to <code>false</code> to disable. disabled; set to <code>true</code> to enable.
</column> </column>
<group title="Tunnel Options: gre only"> <group title="Tunnel Options: gre only">