mir/ovs
2
0
Fork 0
mirror of https://github.com/openvswitch/ovs synced 2025-08-22 18:07:40 +00:00
Code Issues Releases Wiki Activity

ovsdb: Fix commit to disk of rows added to a table with all-default values.

Browse Source
This commit is contained in:
Ben Pfaff 2010-02-12 11:13:24 -08:00
parent 204bad2940
commit 8894256573
2 changed files with 17 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ovsdb/file.c
View File

@ -254,7 +254,7 @@ ovsdb_file_replica_change_cb(const struct ovsdb_row *old,
} else { } else {
struct shash_node *node; struct shash_node *node;
row = NULL; row = old ? NULL : json_object_create();
SHASH_FOR_EACH (node, &new->table->schema->columns) { SHASH_FOR_EACH (node, &new->table->schema->columns) {
const struct ovsdb_column *column = node->data; const struct ovsdb_column *column = node->data;
const struct ovsdb_type *type = &column->type; const struct ovsdb_type *type = &column->type;

16
tests/ovsdb-execution.at
View File

@ -51,6 +51,22 @@ m4_define([OVSDB_CHECK_EXECUTION],
AT_CLEANUP]) AT_CLEANUP])
m4_define([EXECUTION_EXAMPLES], [ m4_define([EXECUTION_EXAMPLES], [
dnl At one point the "commit" code ignored new rows with all-default values,
dnl so this checks for that problem.
OVSDB_CHECK_EXECUTION([insert default row, query table],
[ORDINAL_SCHEMA],
[[[["ordinals",
{"op": "insert",
"table": "ordinals",
"row": {}}]]],
[[["ordinals",
{"op": "select",
"table": "ordinals",
"where": []}]]]],
[[[{"uuid":["uuid","<0>"]}]
[{"rows":[{"_uuid":["uuid","<0>"],"_version":["uuid","<1>"],"name":"","number":0}]}]
]])
OVSDB_CHECK_EXECUTION([insert row, query table], OVSDB_CHECK_EXECUTION([insert row, query table],
[ORDINAL_SCHEMA], [ORDINAL_SCHEMA],
[[[["ordinals", [[[["ordinals",