mir/ovs
2
0
Fork 0
mirror of https://github.com/openvswitch/ovs synced 2025-08-31 06:15:47 +00:00
Code Issues Releases Wiki Activity

ovsdb: Drop regular expression constraints.

Browse Source 
Regular expression constraints have caused nothing but trouble due to the
lack of a ubiquitous regular expression library.  PCRE is *almost*
everywhere, but it has different versions, and different features, and
different bugs, in different places.  It is more trouble than it is worth.
So this commit drops support.
This commit is contained in:
Ben Pfaff
2010-02-23 15:57:50 -08:00
parent 867cc7bd39
commit 89521e3f79
9 changed files with 21 additions and 271 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
lib/ovsdb-data.c
View File

@@ -577,30 +577,6 @@ check_string_constraints(const char *s,
"length %u", s, n_chars, c->maxLen);
}
#if HAVE_PCRE
if (c->re) {
int retval;
retval = pcre_exec(c->re, NULL, s, strlen(s), 0,
PCRE_ANCHORED | PCRE_NO_UTF8_CHECK, NULL, 0);
if (retval == PCRE_ERROR_NOMATCH) {
if (c->reComment) {
return ovsdb_error("constraint violation",
"\"%s\" is not a %s", s, c->reComment);
} else {
return ovsdb_error("constraint violation",
"\"%s\" does not match regular expression "
"/%s/", s, c->reMatch);
}
} else if (retval < 0) {
/* PCRE doesn't have a function to translate an error code to a
* description. Bizarre. See pcreapi(3) for error details. */
return ovsdb_error("internal error", "PCRE returned error %d",
retval);
}
}
#endif /* HAVE_PCRE */
return NULL;
}