mir/ovs
2
0
Fork 0
mirror of https://github.com/openvswitch/ovs synced 2025-08-31 06:15:47 +00:00
Code Issues Releases Wiki Activity

checkpatch: Implement -f option more usefully.

Browse Source 
A lot of checkpatch warnings are only enabled for particular kinds of
files, e.g. C warnings only apply to C source and header files.  The -f
option didn't pass the file name to the code that determines what kinds
of warnings to report, so only generic warnings were actually reported.
This fixes that problem.

Signed-off-by: Ben Pfaff <blp@ovn.org>
Acked-by: Aaron Conole <aconole@redhat.com>
This commit is contained in:
Ben Pfaff
2017-05-26 11:22:36 -07:00
parent b537de13ec
commit 95bd35d3db
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
utilities/checkpatch.py
View File

@@ -284,13 +284,13 @@ def run_checks(current_file, line, lineno):
print("%s\n" % line)
def ovs_checkpatch_parse(text):
global print_file_name, total_line
def ovs_checkpatch_parse(text, filename):
global print_file_name, total_line, checking_file
lineno = 0
signatures = []
co_authors = []
parse = 0
current_file = ''
current_file = filename if checking_file else ''
previous_file = ''
scissors = re.compile(r'^[\w]*---[\w]*')
hunks = re.compile('^(---|\+\+\+) (\S+)')
@@ -397,7 +397,7 @@ def ovs_checkpatch_file(filename):
for part in mail.walk():
if part.get_content_maintype() == 'multipart':
continue
result = ovs_checkpatch_parse(part.get_payload(decode=True))
result = ovs_checkpatch_parse(part.get_payload(decode=True), filename)
if result < 0:
print("Lines checked: %d, Warnings: %d, Errors: %d" %
(total_line, __warnings, __errors))
@@ -446,5 +446,5 @@ if __name__ == '__main__':
if sys.stdin.isatty():
usage()
sys.exit(-1)
sys.exit(ovs_checkpatch_parse(sys.stdin.read()))
sys.exit(ovs_checkpatch_parse(sys.stdin.read()), '-')
sys.exit(ovs_checkpatch_file(filename))