mir/ovs
2
0
Fork 0
mirror of https://github.com/openvswitch/ovs synced 2025-08-31 06:15:47 +00:00
Code Issues Releases Wiki Activity

netdev-dpdk: Secure flow offload API.

Browse Source 
rte API is not thread safe. We have to get netdev mutex
before uing it and also before using fields of netdev structure.

This is important because offload API used from the separate
thread and could be used at the same time with other netdev
functions called from the main thread.

CC: Finn Christensen <fc@napatech.com>
Fixes: e8a2b5bf92 ("netdev-dpdk: implement flow offload with rte flow")
Signed-off-by: Ilya Maximets <i.maximets@samsung.com>
Signed-off-by: Ian Stokes <ian.stokes@intel.com>
This commit is contained in:
Ilya Maximets
2018-10-18 16:29:21 +03:00
committed by Ian Stokes
parent c0af6425d7
commit 95ca79d542
1 changed files with 10 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
lib/netdev-dpdk.c
View File

@@ -4511,15 +4511,21 @@ end_proto_check:
add_flow_pattern(&patterns, RTE_FLOW_ITEM_TYPE_END, NULL, NULL);
struct rte_flow_action_mark mark;
struct rte_flow_action_rss *rss;
mark.id = info->flow_mark;
add_flow_action(&actions, RTE_FLOW_ACTION_TYPE_MARK, &mark);
struct rte_flow_action_rss *rss;
ovs_mutex_lock(&dev->mutex);
rss = add_flow_rss_action(&actions, netdev);
add_flow_action(&actions, RTE_FLOW_ACTION_TYPE_END, NULL);
flow = rte_flow_create(dev->port_id, &flow_attr, patterns.items,
actions.actions, &error);
ovs_mutex_unlock(&dev->mutex);
free(rss);
if (!flow) {
VLOG_ERR("rte flow creat error: %u : message : %s\n",
@@ -4639,6 +4645,8 @@ netdev_dpdk_destroy_rte_flow(struct netdev_dpdk *dev,
struct rte_flow_error error;
int ret;
ovs_mutex_lock(&dev->mutex);
ret = rte_flow_destroy(dev->port_id, rte_flow, &error);
if (ret == 0) {
ufid_to_rte_flow_disassociate(ufid);
@@ -4649,6 +4657,7 @@ netdev_dpdk_destroy_rte_flow(struct netdev_dpdk *dev,
error.type, error.message);
}
ovs_mutex_unlock(&dev->mutex);
return ret;
}