2
0
mirror of https://github.com/openvswitch/ovs synced 2025-08-31 06:15:47 +00:00

checkpatch.py: Fix false positive on if/when/for

We need to use == instead of the is operator. If you're unlucky it may
fail because they're not exactly the same object, but hold the same
value.

Example false positive:

E(120): Inappropriate bracing around statement

+            if (0 != nl_attr_get_u8(vxlan[IFLA_VXLAN_LEARNING])

Fixes: 30c7ffd5ac ("utilities/checkpatch.py: Check for appropriate bracing")
Signed-off-by: Eric Garver <e@erig.me>
Signed-off-by: Russell Bryant <russell@ovn.org>
This commit is contained in:
Eric Garver
2017-03-16 10:22:32 -04:00
committed by Russell Bryant
parent a9c838b2cc
commit 973496b9be

View File

@@ -144,11 +144,11 @@ def if_and_for_end_with_bracket_check(line):
"""This is a rather naive counter - it won't deal with quotes"""
balance = 0
for letter in line:
if letter is '(':
if letter == '(':
balance += 1
elif letter is ')':
elif letter == ')':
balance -= 1
return balance is 0
return balance == 0
if __regex_is_for_if_single_line_bracket.search(line) is not None:
if not balanced_parens(line):