mir/ovs
2
0
Fork 0
mirror of https://github.com/openvswitch/ovs synced 2025-08-30 22:05:19 +00:00
Code Issues Releases Wiki Activity

dpif-netdev: Read recirc depth and flow api enabled once per batch.

Browse Source 
The call to recirc_depth_get involves accessing a TLS value. So read
that once, and store it on the stack for re-use while processing the
batch. The same goes for reading netdev_is_flow_api_enabled(), a
non-inlined function.

Signed-off-by: Balazs Nemeth <bnemeth@redhat.com>
Acked-by: Gaetan Rivet <grive@u256.net>
Acked-by: Paolo Valerio <pvalerio@redhat.com>
Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
This commit is contained in:
Balazs Nemeth
2021-06-28 17:19:14 +02:00
committed by Ilya Maximets
parent e6ad4d8d9c
commit aa4359cb9f
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
lib/dpif-netdev.c
View File

@@ -7151,6 +7151,8 @@ dfc_processing(struct dp_netdev_pmd_thread *pmd,
struct dp_packet *packet; struct dp_packet *packet;
const size_t cnt = dp_packet_batch_size(packets_); const size_t cnt = dp_packet_batch_size(packets_);
uint32_t cur_min = pmd->ctx.emc_insert_min; uint32_t cur_min = pmd->ctx.emc_insert_min;
const uint32_t recirc_depth = *recirc_depth_get();
const bool netdev_flow_api = netdev_is_flow_api_enabled();
int i; int i;
uint16_t tcp_flags; uint16_t tcp_flags;
bool smc_enable_db; bool smc_enable_db;
@@ -7182,7 +7184,7 @@ dfc_processing(struct dp_netdev_pmd_thread *pmd,
pkt_metadata_init(&packet->md, port_no); pkt_metadata_init(&packet->md, port_no);
} }
if (netdev_is_flow_api_enabled() && *recirc_depth_get() == 0) { if (netdev_flow_api && recirc_depth == 0) {
if (OVS_UNLIKELY(dp_netdev_hw_flow(pmd, port_no, packet, &flow))) { if (OVS_UNLIKELY(dp_netdev_hw_flow(pmd, port_no, packet, &flow))) {
/* Packet restoration failed and it was dropped, do not /* Packet restoration failed and it was dropped, do not
* continue processing. * continue processing.