mir/ovs
2
0
Fork 0
mirror of https://github.com/openvswitch/ovs synced 2025-08-31 06:15:47 +00:00
Code Issues Releases Wiki Activity

ovsdb-monitor: Fix valgrind 'possible loss' warnings.

Browse Source 
By placing these nodes at the start of their respective structures,
several "possibly lost" warnings from valgrind are silenced.

Fixes: 60e0cd0419 ("ovsdb: Replication usability improvements")
Signed-off-by: Joe Stringer <joe@ovn.org>
Acked-by: Ben Pfaff <blp@ovn.org>
This commit is contained in:
Joe Stringer
2016-09-09 13:48:52 -07:00
parent 0720377c90
commit ad376c9303
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
ovsdb/jsonrpc-server.c
View File

@@ -1102,9 +1102,9 @@ ovsdb_jsonrpc_trigger_complete_done(struct ovsdb_jsonrpc_session *s)
/* Jsonrpc front end monitor. */ /* Jsonrpc front end monitor. */
struct ovsdb_jsonrpc_monitor { struct ovsdb_jsonrpc_monitor {
struct hmap_node node; /* In ovsdb_jsonrpc_session's "monitors". */
struct ovsdb_jsonrpc_session *session; struct ovsdb_jsonrpc_session *session;
struct ovsdb *db; struct ovsdb *db;
struct hmap_node node; /* In ovsdb_jsonrpc_session's "monitors". */
struct json *monitor_id; struct json *monitor_id;
struct ovsdb_monitor *dbmon; struct ovsdb_monitor *dbmon;
uint64_t unflushed; /* The first transaction that has not been uint64_t unflushed; /* The first transaction that has not been

6
ovsdb/monitor.c
View File

@@ -86,8 +86,8 @@ struct ovsdb_monitor_json_cache_node {
}; };
struct jsonrpc_monitor_node { struct jsonrpc_monitor_node {
struct ovsdb_jsonrpc_monitor *jsonrpc_monitor;
struct ovs_list node; struct ovs_list node;
struct ovsdb_jsonrpc_monitor *jsonrpc_monitor;
}; };
/* A particular column being monitored. */ /* A particular column being monitored. */
@@ -116,12 +116,12 @@ struct ovsdb_monitor_row {
* 'transaction' stores the first update's transaction id. * 'transaction' stores the first update's transaction id.
* */ * */
struct ovsdb_monitor_changes { struct ovsdb_monitor_changes {
struct hmap_node hmap_node; /* Element in ovsdb_monitor_tables' changes
hmap. */
struct ovsdb_monitor_table *mt; struct ovsdb_monitor_table *mt;
struct hmap rows; struct hmap rows;
int n_refs; int n_refs;
uint64_t transaction; uint64_t transaction;
struct hmap_node hmap_node; /* Element in ovsdb_monitor_tables' changes
hmap. */
}; };
/* A particular table being monitored. */ /* A particular table being monitored. */