mir/ovs
2
0
Fork 0
mirror of https://github.com/openvswitch/ovs synced 2025-09-03 15:55:19 +00:00
Code Issues Releases Wiki Activity

netdev-linux: Skip NETDEV_UP test in netdev_linux_set_etheraddr() for taps.

Browse Source 
netdev_turn_flags_off() does nothing if the flags that one turns off are
already off.

Reported-by: Ethan Jackson <ethan@nicira.com>
Signed-off-by: Ben Pfaff <blp@nicira.com>
Acked-by: Ethan Jackson <ethan@nicira.com>
This commit is contained in:
Ben Pfaff
2013-05-13 16:39:26 -07:00
parent 8dbe1f9fbf
commit bbd5b6f44b
1 changed files with 1 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
lib/netdev-linux.c
View File

@@ -977,11 +977,7 @@ netdev_linux_set_etheraddr(struct netdev *netdev_,
/* Tap devices must be brought down before setting the address. */
if (is_tap_netdev(netdev_)) {
enum netdev_flags flags;
if (!netdev_get_flags(netdev_, &flags) && (flags & NETDEV_UP)) {
netdev_turn_flags_off(netdev_, NETDEV_UP, &sf);
}
netdev_turn_flags_off(netdev_, NETDEV_UP, &sf);
}
error = set_etheraddr(netdev_get_name(netdev_), mac);
if (!error || error == ENODEV) {