mir/ovs
2
0
Fork 0
mirror of https://github.com/openvswitch/ovs synced 2025-08-30 22:05:19 +00:00
Code Issues Releases Wiki Activity

checkpatch: Don't allow Gerrit Change-Ids.

Browse Source 
Local Gerrit Change-Ids are not welcome in common repository.
Inspired by checkpatch.pl from Linux Kernel.

Signed-off-by: Ilya Maximets <i.maximets@samsung.com>
Acked-by: Aaron Conole <aconole@redhat.com>
Signed-off-by: Russell Bryant <russell@ovn.org>
This commit is contained in:
Ilya Maximets
2017-07-14 13:57:21 +03:00
committed by Russell Bryant
parent 5ca8912738
commit bc03d850d6
1 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
utilities/checkpatch.py
View File

@@ -320,6 +320,8 @@ def ovs_checkpatch_parse(text, filename):
re.I | re.M | re.S)
is_co_author = re.compile(r'(\s*(Co-authored-by: )(.*))$',
re.I | re.M | re.S)
is_gerrit_change_id = re.compile(r'(\s*(change-id: )(.*))$',
re.I | re.M | re.S)
for line in text.split('\n'):
if current_file != previous_file:
@@ -357,6 +359,10 @@ def ovs_checkpatch_parse(text, filename):
elif is_co_author.match(line):
m = is_co_author.match(line)
co_authors.append(m.group(3))
elif is_gerrit_change_id.match(line):
print_error(
"Remove Gerrit Change-Id's before submitting upstream.")
print("%d: %s\n" % (lineno, line))
elif parse == 2:
newfile = hunks.match(line)
if newfile: