mirror of
https://github.com/openvswitch/ovs
synced 2025-09-05 08:45:23 +00:00
coverage: Synchronize per-thread counters less aggressively
When profiling CPU usage in situations involving high numbers of ports, coverage_clear() was highlighted as a commonly called function. It appears that it can be quite expensive to access all of the per-thread coverage counters when threads are constantly waking up. This patch makes each thread only do coverage_clear() logic roughly once per second by introducing per-thread timers. Upcall handler counters may become less accurate, as these threads may sleep without synchronising and not wake up for some time. When the main thread is under load at ~90% CPU, this drops to ~85%. Upcall handler threads sitting at ~2.5% drop to ~1.5%. Signed-off-by: Joe Stringer <joestringer@nicira.com> Signed-off-by: Ben Pfaff <blp@nicira.com>
This commit is contained in:
@@ -36,6 +36,9 @@
|
||||
#define COVERAGE_RUN_INTERVAL 5000
|
||||
BUILD_ASSERT_DECL(60000 % COVERAGE_RUN_INTERVAL == 0);
|
||||
|
||||
#define COVERAGE_CLEAR_INTERVAL 1000
|
||||
BUILD_ASSERT_DECL(COVERAGE_RUN_INTERVAL % COVERAGE_CLEAR_INTERVAL == 0);
|
||||
|
||||
/* Defines the moving average array length. */
|
||||
#define MIN_AVG_LEN (60000/COVERAGE_RUN_INTERVAL)
|
||||
#define HR_AVG_LEN 60
|
||||
|
Reference in New Issue
Block a user