mir/ovs
2
0
Fork 0
mirror of https://github.com/openvswitch/ovs synced 2025-09-01 14:55:18 +00:00
Code Issues Releases Wiki Activity

datapath: fix drvinfo strings set in drivers

Browse Source 
Use strlcpy where possible to ensure the string is \0 terminated.
Use always sizeof(string) instead of 32, ETHTOOL_BUSINFO_LEN
and custom defines.
Use snprintf instead of sprint.
Remove unnecessary inits of ->fw_version
Remove unnecessary inits of drvinfo struct.

Signed-off-by: Jiri Pirko <jiri@resnulli.us>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Jesse Gross <jesse@nicira.com>
This commit is contained in:
Jiri Pirko
2013-03-14 17:36:37 -07:00
committed by Jesse Gross
parent 7941601161
commit c58a0a6b32
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
datapath/vport-internal_dev.c
View File

@@ -115,7 +115,7 @@ static int internal_dev_stop(struct net_device *netdev)
static void internal_dev_getinfo(struct net_device *netdev, static void internal_dev_getinfo(struct net_device *netdev,
struct ethtool_drvinfo *info) struct ethtool_drvinfo *info)
{ {
strcpy(info->driver, "openvswitch"); strlcpy(info->driver, "openvswitch", sizeof(info->driver));
} }
static const struct ethtool_ops internal_dev_ethtool_ops = { static const struct ethtool_ops internal_dev_ethtool_ops = {