mirror of
https://github.com/openvswitch/ovs
synced 2025-08-30 22:05:19 +00:00
checkpatch: Correct line count in error messages.
As part of some previous checkpatch work, we discovered that checkpatch isn't always reporting correct line numbers. As it turns out, Python's splitlines function considers several characters to be new lines which common text editors do not typically consider to be new lines. For example, form feed characters, which this code base uses to cluster functionality. Signed-off-by: Mike Pattrick <mkp@redhat.com> Acked-by: Paolo Valerio <pvalerio@redhat.com> Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
This commit is contained in:
committed by
Ilya Maximets
parent
28ef2535c1
commit
d652fc6a5a
@@ -765,12 +765,16 @@ def ovs_checkpatch_parse(text, filename, author=None, committer=None):
|
||||
|
||||
reset_counters()
|
||||
|
||||
for line in text.splitlines():
|
||||
for line in text.split("\n"):
|
||||
if current_file != previous_file:
|
||||
previous_file = current_file
|
||||
|
||||
lineno = lineno + 1
|
||||
total_line = total_line + 1
|
||||
|
||||
if line == "\f":
|
||||
# Form feed
|
||||
continue
|
||||
if len(line) <= 0:
|
||||
continue
|
||||
|
||||
|
Reference in New Issue
Block a user