mir/ovs
2
0
Fork 0
mirror of https://github.com/openvswitch/ovs synced 2025-08-31 22:35:15 +00:00
Code Issues Releases Wiki Activity

db-ctl-base: Initialize the output variable in the ctx structure.

Browse Source 
Coverity was flagged that the uninitialized output variable was used
in the ctl_context_init_command() function. This patch initializes
the variable.

In addition it also destroys the ds string in ctl_context_done()
in case it's not cleared properly.

Fixes: 07ff77ccb8 ("db-ctl-base: Make common database command code into library.")
Acked-by: Ilya Maximets <i.maximets@ovn.org>
Acked-by: Paolo Valerio <pvalerio@redhat.com>
Signed-off-by: Eelco Chaudron <echaudro@redhat.com>
This commit is contained in:
Eelco Chaudron
2024-05-29 12:53:32 +02:00
parent 361d7bce0f
commit d97eee88e5
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/db-ctl-base.c
View File

@@ -2656,6 +2656,7 @@ ctl_context_init(struct ctl_context *ctx, struct ctl_command *command,
struct ovsdb_symbol_table *symtab,
void (*invalidate_cache_cb)(struct ctl_context *))
{
ds_init(&ctx->output);
if (command) {
ctl_context_init_command(ctx, command, false);
}
@@ -2688,6 +2689,7 @@ ctl_context_done(struct ctl_context *ctx,
ctl_context_done_command(ctx, command);
}
invalidate_cache(ctx);
ds_destroy(&ctx->output);
}
char * OVS_WARN_UNUSED_RESULT