mir/ovs
2
0
Fork 0
mirror of https://github.com/openvswitch/ovs synced 2025-08-31 14:25:26 +00:00
Code Issues Releases Wiki Activity

ovsdb-error: Annotate non-null functions.

Browse Source 
The Clang analyzer has trouble detecting that functions can never return
null in certain conditions, this results in several false "Dereference of
null pointer" detections.

This patch annotates functions that call ovsdb_error_valist()
unconditionally as non-null, as this function will either return a valid
pointer or call abort().

Acked-by: Simon Horman <horms@ovn.org>
Signed-off-by: Mike Pattrick <mkp@redhat.com>
Signed-off-by: Eelco Chaudron <echaudro@redhat.com>
This commit is contained in:
Mike Pattrick
2024-09-09 00:54:58 -04:00
committed by Eelco Chaudron
parent bd48ff8f7d
commit e48ba271f4
1 changed files with 10 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
lib/ovsdb-error.h
View File

@@ -22,14 +22,17 @@ struct json;
struct ovsdb_error *ovsdb_error(const char *tag, const char *details, ...)
OVS_PRINTF_FORMAT(2, 3)
OVS_WARN_UNUSED_RESULT;
OVS_WARN_UNUSED_RESULT
OVS_RETURNS_NONNULL;
struct ovsdb_error *ovsdb_io_error(int error, const char *details, ...)
OVS_PRINTF_FORMAT(2, 3)
OVS_WARN_UNUSED_RESULT;
OVS_WARN_UNUSED_RESULT
OVS_RETURNS_NONNULL;
struct ovsdb_error *ovsdb_syntax_error(const struct json *, const char *tag,
const char *details, ...)
OVS_PRINTF_FORMAT(3, 4)
OVS_WARN_UNUSED_RESULT;
OVS_WARN_UNUSED_RESULT
OVS_RETURNS_NONNULL;
struct ovsdb_error *ovsdb_wrap_error(struct ovsdb_error *error,
const char *details, ...)
@@ -39,11 +42,13 @@ struct ovsdb_error *ovsdb_internal_error(struct ovsdb_error *error,
const char *file, int line,
const char *details, ...)
OVS_PRINTF_FORMAT(4, 5)
OVS_WARN_UNUSED_RESULT;
OVS_WARN_UNUSED_RESULT
OVS_RETURNS_NONNULL;
struct ovsdb_error *ovsdb_perm_error(const char *details, ...)
OVS_PRINTF_FORMAT(1, 2)
OVS_WARN_UNUSED_RESULT;
OVS_WARN_UNUSED_RESULT
OVS_RETURNS_NONNULL;
/* Returns a pointer to an ovsdb_error that represents an internal error for
* the current file name and line number with MSG as the associated message.