From ec6edc8cde730704b007ab7b35b35bb39c2083e8 Mon Sep 17 00:00:00 2001 From: Ilya Maximets Date: Mon, 30 Oct 2017 15:52:38 +0300 Subject: [PATCH] netdev-dpdk: Fix mp_name leak on snprintf failure. CC: Robert Wojciechowicz CC: Antonio Fischetti Fixes: d555d9bded5f ("netdev-dpdk: Create separate memory pool for each port.") Fixes: 65056fd79694 ("netdev-dpdk: manage failure in mempool name creation.") Signed-off-by: Ilya Maximets Signed-off-by: Ben Pfaff --- lib/netdev-dpdk.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c index 82652f0c0..1e9d78f58 100644 --- a/lib/netdev-dpdk.c +++ b/lib/netdev-dpdk.c @@ -505,6 +505,7 @@ dpdk_mp_name(struct dpdk_mp *dmp) VLOG_DBG("snprintf returned %d. Failed to generate a mempool " "name for \"%s\". Hash:0x%x, mtu:%d, mbufs:%u.", ret, dmp->if_name, h, dmp->mtu, dmp->n_mbufs); + free(mp_name); return NULL; } return mp_name;