mir/ovs
2
0
Fork 0
mirror of https://github.com/openvswitch/ovs synced 2025-08-31 22:35:15 +00:00
Code Issues Releases Wiki Activity

netdev-offload-tc: Use single 'once' variable for probing tc features

Browse Source 
There is no need for a 'once' variable per probe.

Signed-off-by: Roi Dayan <roid@nvidia.com>
Reviewed-by: Paul Blakey <paulb@mellanox.com>
Signed-off-by: Simon Horman <simon.horman@netronome.com>
This commit is contained in:
Roi Dayan
2020-11-11 12:07:55 +02:00
committed by Simon Horman
parent 193995f81c
commit ecadc3a30b
1 changed files with 3 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
lib/netdev-offload-tc.c
View File

@@ -1988,8 +1988,7 @@ probe_tc_block_support(int ifindex)
static int static int
netdev_tc_init_flow_api(struct netdev *netdev) netdev_tc_init_flow_api(struct netdev *netdev)
{ {
static struct ovsthread_once multi_mask_once = OVSTHREAD_ONCE_INITIALIZER; static struct ovsthread_once once = OVSTHREAD_ONCE_INITIALIZER;
static struct ovsthread_once block_once = OVSTHREAD_ONCE_INITIALIZER;
enum tc_qdisc_hook hook = get_tc_qdisc_hook(netdev); enum tc_qdisc_hook hook = get_tc_qdisc_hook(netdev);
uint32_t block_id = 0; uint32_t block_id = 0;
struct tcf_id id; struct tcf_id id;
@@ -2014,16 +2013,13 @@ netdev_tc_init_flow_api(struct netdev *netdev)
/* make sure there is no ingress/egress qdisc */ /* make sure there is no ingress/egress qdisc */
tc_add_del_qdisc(ifindex, false, 0, hook); tc_add_del_qdisc(ifindex, false, 0, hook);
if (ovsthread_once_start(&block_once)) { if (ovsthread_once_start(&once)) {
probe_tc_block_support(ifindex); probe_tc_block_support(ifindex);
/* Need to re-fetch block id as it depends on feature availability. */ /* Need to re-fetch block id as it depends on feature availability. */
block_id = get_block_id_from_netdev(netdev); block_id = get_block_id_from_netdev(netdev);
ovsthread_once_done(&block_once);
}
if (ovsthread_once_start(&multi_mask_once)) {
probe_multi_mask_per_prio(ifindex); probe_multi_mask_per_prio(ifindex);
ovsthread_once_done(&multi_mask_once); ovsthread_once_done(&once);
} }
error = tc_add_del_qdisc(ifindex, true, block_id, hook); error = tc_add_del_qdisc(ifindex, true, block_id, hook);