mir/ovs
2
0
Fork 0
mirror of https://github.com/openvswitch/ovs synced 2025-08-31 14:25:26 +00:00
Code Issues Releases Wiki Activity

netdev-*: Do not use dp_packet_pad() in recv() functions.

Browse Source 
All the netdevs used by dpif-netdev (except for netdev-dpdk) have a
dp_packet_pad() call in the receive function, probably because the
userspace datapath couldn't handle properly short packets.

This doesn't appear to be the case anymore.

This commit removes the call to have a more consistent behavior with the
kernel datapath.

All the testsuite changes in this commit adjust the expectations for
packet lengths in flow dumps and other stats.  There's only one fix in
ovn.at: one of the test_ip() functions generated an incomplete udp
packet, which was not a problem until now, because of the padding.

Signed-off-by: Daniele Di Proietto <diproiettod@vmware.com>
Acked-by: Ben Pfaff <blp@ovn.org>
This commit is contained in:
Daniele Di Proietto
2016-07-28 18:02:01 -07:00
parent ac1432a467
commit efe179e041
8 changed files with 367 additions and 395 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
lib/netdev-bsd.c
View File

@@ -639,7 +639,6 @@ netdev_bsd_rxq_recv(struct netdev_rxq *rxq_, struct dp_packet_batch *batch)
if (retval) {
dp_packet_delete(packet);
} else {
dp_packet_pad(packet);
batch->packets[0] = packet;
batch->count = 1;
}