mir/ovs
2
0
Fork 0
mirror of https://github.com/openvswitch/ovs synced 2025-08-31 06:15:47 +00:00
Code Issues Releases Wiki Activity

netdev-linux: Fix fd leak on error path.

Browse Source 
Found by inspection.

Signed-off-by: Ben Pfaff <blp@nicira.com>
This commit is contained in:
Ben Pfaff
2013-07-25 17:03:03 -07:00
parent 59e0c910d0
commit f61d8d2931
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
lib/netdev-linux.c
View File

@@ -672,19 +672,21 @@ netdev_linux_create_tap(const struct netdev_class *class OVS_UNUSED,
VLOG_WARN("%s: creating tap device failed: %s", name,
ovs_strerror(errno));
error = errno;
goto error_unref_notifier;
goto error_close;
}
/* Make non-blocking. */
error = set_nonblocking(state->fd);
if (error) {
goto error_unref_notifier;
goto error_close;
}
netdev_init(&netdev->up, name, &netdev_tap_class);
*netdevp = &netdev->up;
return 0;
error_close:
close(state->fd);
error_unref_notifier:
cache_notifier_unref();
error: