mir/ovs
2
0
Fork 0
mirror of https://github.com/openvswitch/ovs synced 2025-08-31 06:15:47 +00:00
Code Issues Releases Wiki Activity

dp-packet: Reset DPDK hwol flags on init.

Browse Source 
Reset the DPDK hwol flags in dp_packet_init_.  The new hwol bad checksum
flag is uninitialized for non-dpdk ports and this is noticed as test
failures using netdev-dummy ports, when built with the --with-dpdk
flag set. Hence, in this case, packets may be falsely marked as having a
bad checksum. The existing APIs are simplified at the same time by
making them specific to either DPDK or otherwise; they also now
manage a single field.

Reported-at: https://mail.openvswitch.org/pipermail/ovs-discuss/2017-August/045081.html
Fixes: 7451af618e ("dp-packet : Update DPDK rx checksum validation functions.")
CC: Sugesh Chandran <sugesh.chandran@intel.com>
Signed-off-by: Darrell Ball <dlu998@gmail.com>
Signed-off-by: Ben Pfaff <blp@ovn.org>
This commit is contained in:
Darrell Ball
2017-08-10 13:22:16 -07:00
committed by Ben Pfaff
parent ea5dbd792d
commit f8121b3912
3 changed files with 23 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/netdev-dpdk.c
View File

@@ -2916,7 +2916,7 @@ netdev_dpdk_ring_send(struct netdev *netdev, int qid,
* modified by the consumer of the ring and return into the datapath
* without recalculating the RSS hash. */
for (i = 0; i < batch->count; i++) {
dp_packet_rss_invalidate(batch->packets[i]);
dp_packet_mbuf_rss_flag_reset(batch->packets[i]);
}
netdev_dpdk_send__(dev, qid, batch, may_steal, concurrent_txq);