mir/ovs
2
0
Fork 0
mirror of https://github.com/openvswitch/ovs synced 2025-09-03 15:55:19 +00:00
Code Issues Releases Wiki Activity

dpif-linux: Add missing NLM_F_ECHO flag to flow requests.

Browse Source 
Flow transactions expect a response after the operation has completed
but the request did not have NLM_F_ECHO set.  This caused userspace
to receive only the Netlink ACK instead of a real response, making
it appear that the operation had failed when it actually succeeded.
This commit is contained in:
Jesse Gross
2011-01-29 18:09:37 -08:00
parent 4ca85130db
commit f9ef1c31cf
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
lib/dpif-linux.c
View File

@@ -1449,7 +1449,8 @@ dpif_linux_flow_to_ofpbuf(const struct dpif_linux_flow *flow,
struct odp_header *odp_header; struct odp_header *odp_header;
nl_msg_put_genlmsghdr(buf, 0, odp_flow_family, nl_msg_put_genlmsghdr(buf, 0, odp_flow_family,
NLM_F_REQUEST | flow->nlmsg_flags, flow->cmd, 1); NLM_F_REQUEST | NLM_F_ECHO | flow->nlmsg_flags,
flow->cmd, 1);
odp_header = ofpbuf_put_uninit(buf, sizeof *odp_header); odp_header = ofpbuf_put_uninit(buf, sizeof *odp_header);
odp_header->dp_ifindex = flow->dp_ifindex; odp_header->dp_ifindex = flow->dp_ifindex;