mir/ovs
2
0
Fork 0
mirror of https://github.com/openvswitch/ovs synced 2025-08-31 14:25:26 +00:00
Code Issues Releases Wiki Activity

ofp-errors: Remove OFPERR_NXFMFC_GROUPS_NOT_SUPPORTED

Browse Source 
OFPERR_NXFMFC_GROUPS_NOT_SUPPORTED is currently only used in paths which
are part of a non-NX extension portions of the Open Flow 1.1+
implementation.

After recent discussion it has been decided to attempt to only use
standardised, albeit lest-specify, errors unless errors arise from use of
an NX extension.

With the above in mind it seems appropriate to:
* Use OFPERR_OFPFMFC_UNKNOWN in place of OFPERR_NXFMFC_GROUPS_NOT_SUPPORTED.
* Remove OFPERR_NXFMFC_GROUPS_NOT_SUPPORTED as it is no longer used.

An unfortunate side-effect of this change is that the error for
the case in question is now less-specific.

Signed-off-by: Simon Horman <horms@verge.net.au>
Signed-off-by: Ben Pfaff <blp@nicira.com>
This commit is contained in:
Simon Horman
2012-09-04 15:52:00 +09:00
committed by Ben Pfaff
parent e38c9de5db
commit fb9515e1fd
2 changed files with 2 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
lib/ofp-errors.h
View File

@@ -337,9 +337,6 @@ enum ofperr {
* extension is enabled. */
OFPERR_NXFMFC_BAD_TABLE_ID,
/* NX1.0+(3,258). 'out_group' specified but groups not yet supported. */
OFPERR_NXFMFC_GROUPS_NOT_SUPPORTED,
/* ## ---------------------- ## */
/* ## OFPET_GROUP_MOD_FAILED ## */
/* ## ---------------------- ## */

4
lib/ofp-util.c
View File

@@ -1171,7 +1171,7 @@ ofputil_decode_flow_mod(struct ofputil_flow_mod *fm,
return error;
}
if (ofm->out_group != htonl(OFPG_ANY)) {
return OFPERR_NXFMFC_GROUPS_NOT_SUPPORTED;
return OFPERR_OFPFMFC_UNKNOWN;
}
fm->flags = ntohs(ofm->flags);
} else {
@@ -1410,7 +1410,7 @@ ofputil_decode_ofpst11_flow_request(struct ofputil_flow_stats_request *fsr,
return error;
}
if (ofsr->out_group != htonl(OFPG11_ANY)) {
return OFPERR_NXFMFC_GROUPS_NOT_SUPPORTED;
return OFPERR_OFPFMFC_UNKNOWN;
}
fsr->cookie = ofsr->cookie;
fsr->cookie_mask = ofsr->cookie_mask;