mirror of
https://github.com/openvswitch/ovs
synced 2025-08-22 01:51:26 +00:00
1ca0323e7c
Python 2 reaches end-of-life on January 1, 2020, which is only a few months away. This means that OVS needs to stop depending on in the next release that should occur roughly that same time. Therefore, this commit removes all support for Python 2. It also makes Python 3 a mandatory build dependency. Some of the interesting consequences: - HAVE_PYTHON, HAVE_PYTHON2, and HAVE_PYTHON3 conditionals have been removed, since we now know that Python3 is available. - $PYTHON and $PYTHON2 are removed, and $PYTHON3 is always available. - Many tests for Python 2 support have been removed, and the ones that depended on Python 3 now run unconditionally. This allowed several macros in the testsuite to be removed, making the code clearer. This does make some of the changes to the testsuite files large due to indentation level changes. - #! lines for Python now use /usr/bin/python3 instead of /usr/bin/python. - Packaging depends on Python 3 packages. Acked-by: Numan Siddique <nusiddiq@redhat.com> Tested-by: Numan Siddique <nusiddiq@redhat.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
56 lines
1.2 KiB
Plaintext
56 lines
1.2 KiB
Plaintext
AT_BANNER([struct alignment checker unit tests])
|
|
|
|
m4_define([check_structs], [$top_srcdir/build-aux/check-structs])
|
|
m4_define([RUN_STRUCT_CHECKER],
|
|
[AT_KEYWORDS([check-structs])
|
|
AT_DATA([test.h], [$1
|
|
])
|
|
AT_CHECK_UNQUOTED([$PYTHON3 check_structs test.h], [$2], [$3], [$4])])
|
|
|
|
AT_SETUP([check struct tail padding])
|
|
RUN_STRUCT_CHECKER(
|
|
[struct xyz {
|
|
ovs_be16 x;
|
|
};],
|
|
[1], [],
|
|
[test.h:3: warning: struct xyz needs 2 bytes of tail padding
|
|
])
|
|
AT_CLEANUP
|
|
|
|
AT_SETUP([check struct internal alignment])
|
|
RUN_STRUCT_CHECKER(
|
|
[struct xyzzy {
|
|
ovs_be16 x;
|
|
ovs_be32 y;
|
|
};],
|
|
[1], [],
|
|
[test.h:3: warning: struct xyzzy member y is 2 bytes short of 4-byte alignment
|
|
])
|
|
AT_CLEANUP
|
|
|
|
AT_SETUP([check struct declared size])
|
|
RUN_STRUCT_CHECKER(
|
|
[struct wibble {
|
|
ovs_be64 z;
|
|
};
|
|
OFP_ASSERT(sizeof(struct wibble) == 12);
|
|
],
|
|
[1], [],
|
|
[test.h:4: warning: struct wibble is 8 bytes long but declared as 12
|
|
])
|
|
AT_CLEANUP
|
|
|
|
AT_SETUP([check wrong struct's declared size])
|
|
RUN_STRUCT_CHECKER(
|
|
[struct moo {
|
|
ovs_be64 bar;
|
|
};
|
|
OFP_ASSERT(sizeof(struct moo) == 8);
|
|
struct wibble {
|
|
ovs_be64 z;
|
|
};
|
|
OFP_ASSERT(sizeof(struct moo) == 8);
|
|
], [1], [], [test.h:8: warning: checking size of struct moo but struct wibble was most recently defined
|
|
])
|
|
AT_CLEANUP
|