2
0
mirror of https://github.com/openvswitch/ovs synced 2025-08-22 09:58:01 +00:00
ovs/lib/ovsdb-types.h
Ilya Maximets 6f11d9daad ovsdb: transaction: Avoid diffs for different type references.
While counting strong references current code first generates a
difference between old and new datums and only after it checks
the types of the atoms to be strong references.

Similar thing happens while assessing weak references.  First
the added/removed are generated and then we check for atoms
to be weak references.

Check the type first to avoid unnecessary work.  This change
doubles the performance of transactions that modify large sets
of references.

For example, with this change applied, initial read of OVSDB
file containing 136K transactions of large OVN port groups
and address sets on my laptop takes 24 seconds vs 43 seconds
without.

Fixes: 4dbff9f0a685 ("ovsdb: transaction: Incremental reassessment of weak refs.")
Fixes: b2712d026eae ("ovsdb: transaction: Use diffs for strong reference counting.")
Acked-by: Mike Pattrick <mkp@redhat.com>
Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
2024-01-08 22:41:15 +01:00

258 lines
8.9 KiB
C
Raw Blame History

This file contains invisible Unicode characters

This file contains invisible Unicode characters that are indistinguishable to humans but may be processed differently by a computer. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.

/* Copyright (c) 2009, 2010, 2011 Nicira, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at:
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
#ifndef OVSDB_TYPES_H
#define OVSDB_TYPES_H 1
#include <float.h>
#include <stdbool.h>
#include <stdint.h>
#include "compiler.h"
#include "uuid.h"
#ifdef __cplusplus
extern "C" {
#endif
struct json;
/* An atomic type: one that OVSDB regards as a single unit of data. */
enum ovsdb_atomic_type {
OVSDB_TYPE_VOID, /* No value. */
OVSDB_TYPE_INTEGER, /* Signed 64-bit integer. */
OVSDB_TYPE_REAL, /* IEEE 754 double-precision floating point. */
OVSDB_TYPE_BOOLEAN, /* True or false. */
OVSDB_TYPE_STRING, /* UTF-8 string. */
OVSDB_TYPE_UUID, /* RFC 4122 UUID referencing a table row. */
OVSDB_N_TYPES
};
static inline bool ovsdb_atomic_type_is_valid(enum ovsdb_atomic_type);
bool ovsdb_atomic_type_from_string(const char *, enum ovsdb_atomic_type *);
struct ovsdb_error *ovsdb_atomic_type_from_json(enum ovsdb_atomic_type *,
const struct json *);
const char *ovsdb_atomic_type_to_string(enum ovsdb_atomic_type);
struct json *ovsdb_atomic_type_to_json(enum ovsdb_atomic_type);
/* An atomic type plus optional constraints. */
enum ovsdb_ref_type {
OVSDB_REF_STRONG, /* Target must exist. */
OVSDB_REF_WEAK /* Delete reference if target disappears. */
};
struct ovsdb_integer_constraints {
int64_t min; /* minInteger or INT64_MIN. */
int64_t max; /* maxInteger or INT64_MAX. */
};
struct ovsdb_real_constraints {
double min; /* minReal or -DBL_MAX. */
double max; /* minReal or DBL_MAX. */
};
struct ovsdb_string_constraints {
unsigned int minLen; /* minLength or 0. */
unsigned int maxLen; /* maxLength or UINT_MAX. */
};
struct ovsdb_uuid_constraints {
char *refTableName; /* Name of referenced table, or NULL. */
struct ovsdb_table *refTable; /* Referenced table, if available. */
enum ovsdb_ref_type refType; /* Reference type. */
};
struct ovsdb_base_type {
enum ovsdb_atomic_type type;
/* If nonnull, a datum with keys of type 'type' that expresses all the
* valid values for this base_type. */
struct ovsdb_datum *enum_;
union {
struct ovsdb_integer_constraints integer;
struct ovsdb_real_constraints real;
/* No constraints for Boolean types. */
struct ovsdb_string_constraints string;
struct ovsdb_uuid_constraints uuid;
};
};
#define OVSDB_BASE_VOID_INIT { .type = OVSDB_TYPE_VOID }
#define OVSDB_BASE_INTEGER_INIT { .type = OVSDB_TYPE_INTEGER, \
.integer = { INT64_MIN, INT64_MAX } }
#define OVSDB_BASE_REAL_INIT { .type = OVSDB_TYPE_REAL, \
.real = { -DBL_MAX, DBL_MAX } }
#define OVSDB_BASE_BOOLEAN_INIT { .type = OVSDB_TYPE_BOOLEAN }
#define OVSDB_BASE_STRING_INIT { .type = OVSDB_TYPE_STRING, \
.string = { 0, UINT_MAX } }
#define OVSDB_BASE_UUID_INIT { .type = OVSDB_TYPE_UUID, \
.uuid = { NULL, NULL, 0 } }
void ovsdb_base_type_init(struct ovsdb_base_type *, enum ovsdb_atomic_type);
void ovsdb_base_type_clone(struct ovsdb_base_type *,
const struct ovsdb_base_type *);
void ovsdb_base_type_destroy(struct ovsdb_base_type *);
bool ovsdb_base_type_is_valid(const struct ovsdb_base_type *);
bool ovsdb_base_type_equals(const struct ovsdb_base_type *,
const struct ovsdb_base_type *);
bool ovsdb_base_type_has_constraints(const struct ovsdb_base_type *);
void ovsdb_base_type_clear_constraints(struct ovsdb_base_type *);
const struct ovsdb_type *ovsdb_base_type_get_enum_type(enum ovsdb_atomic_type);
struct ovsdb_error *ovsdb_base_type_from_json(struct ovsdb_base_type *,
const struct json *)
OVS_WARN_UNUSED_RESULT;
struct json *ovsdb_base_type_to_json(const struct ovsdb_base_type *);
static inline bool ovsdb_base_type_is_ref(const struct ovsdb_base_type *);
static inline bool ovsdb_base_type_is_strong_ref(
const struct ovsdb_base_type *);
static inline bool ovsdb_base_type_is_weak_ref(const struct ovsdb_base_type *);
/* An OVSDB type.
*
* Several rules constrain the valid types. See ovsdb_type_is_valid() (in
* ovsdb-types.c) for details.
*
* If 'value_type' is OVSDB_TYPE_VOID, 'n_min' is 1, and 'n_max' is 1, then the
* type is a single atomic 'key_type'.
*
* If 'value_type' is OVSDB_TYPE_VOID and 'n_min' or 'n_max' (or both) has a
* value other than 1, then the type is a set of 'key_type'. If 'n_min' is 0
* and 'n_max' is 1, then the type can also be considered an optional
* 'key_type'.
*
* If 'value_type' is not OVSDB_TYPE_VOID, then the type is a map from
* 'key_type' to 'value_type'. If 'n_min' is 0 and 'n_max' is 1, then the type
* can also be considered an optional pair of 'key_type' and 'value_type'.
*/
struct ovsdb_type {
struct ovsdb_base_type key;
struct ovsdb_base_type value;
unsigned int n_min;
unsigned int n_max; /* UINT_MAX stands in for "unlimited". */
};
#define OVSDB_TYPE_SCALAR_INITIALIZER(KEY) { KEY, OVSDB_BASE_VOID_INIT, 1, 1 }
extern const struct ovsdb_type ovsdb_type_integer;
extern const struct ovsdb_type ovsdb_type_real;
extern const struct ovsdb_type ovsdb_type_boolean;
extern const struct ovsdb_type ovsdb_type_string;
extern const struct ovsdb_type ovsdb_type_uuid;
void ovsdb_type_clone(struct ovsdb_type *, const struct ovsdb_type *);
void ovsdb_type_destroy(struct ovsdb_type *);
bool ovsdb_type_is_valid(const struct ovsdb_type *);
bool ovsdb_type_equals(const struct ovsdb_type *, const struct ovsdb_type *);
static inline bool ovsdb_type_is_scalar(const struct ovsdb_type *);
static inline bool ovsdb_type_is_optional(const struct ovsdb_type *);
static inline bool ovsdb_type_is_optional_scalar(
const struct ovsdb_type *);
static inline bool ovsdb_type_is_composite(const struct ovsdb_type *);
static inline bool ovsdb_type_is_set(const struct ovsdb_type *);
static inline bool ovsdb_type_is_map(const struct ovsdb_type *);
char *ovsdb_type_to_english(const struct ovsdb_type *);
struct ovsdb_error *ovsdb_type_from_json(struct ovsdb_type *,
const struct json *)
OVS_WARN_UNUSED_RESULT;
struct json *ovsdb_type_to_json(const struct ovsdb_type *);
/* Inline function implementations. */
static inline bool
ovsdb_atomic_type_is_valid(enum ovsdb_atomic_type atomic_type)
{
return (int) atomic_type >= 0 && atomic_type < OVSDB_N_TYPES;
}
static inline bool
ovsdb_base_type_is_ref(const struct ovsdb_base_type *base)
{
return base->type == OVSDB_TYPE_UUID && base->uuid.refTableName;
}
static inline bool
ovsdb_base_type_is_strong_ref(const struct ovsdb_base_type *base)
{
return (ovsdb_base_type_is_ref(base)
&& base->uuid.refType == OVSDB_REF_STRONG);
}
static inline bool
ovsdb_base_type_is_weak_ref(const struct ovsdb_base_type *base)
{
return (ovsdb_base_type_is_ref(base)
&& base->uuid.refType == OVSDB_REF_WEAK);
}
static inline bool ovsdb_type_is_scalar(const struct ovsdb_type *type)
{
return (type->value.type == OVSDB_TYPE_VOID
&& type->n_min == 1 && type->n_max == 1);
}
static inline bool ovsdb_type_is_optional(const struct ovsdb_type *type)
{
return type->n_min == 0;
}
static inline bool ovsdb_type_is_optional_scalar(
const struct ovsdb_type *type)
{
return (type->value.type == OVSDB_TYPE_VOID
&& type->n_min == 0 && type->n_max == 1);
}
static inline bool ovsdb_type_is_composite(const struct ovsdb_type *type)
{
return type->n_max > 1;
}
static inline bool ovsdb_type_is_set(const struct ovsdb_type *type)
{
return (type->value.type == OVSDB_TYPE_VOID
&& (type->n_min != 1 || type->n_max != 1));
}
static inline bool ovsdb_type_is_map(const struct ovsdb_type *type)
{
return type->value.type != OVSDB_TYPE_VOID;
}
static inline bool ovsdb_type_has_strong_refs(const struct ovsdb_type *type)
{
return ovsdb_base_type_is_strong_ref(&type->key)
|| ovsdb_base_type_is_strong_ref(&type->value);
}
static inline bool ovsdb_type_has_weak_refs(const struct ovsdb_type *type)
{
return ovsdb_base_type_is_weak_ref(&type->key)
|| ovsdb_base_type_is_weak_ref(&type->value);
}
#ifdef __cplusplus
}
#endif
#endif /* ovsdb-types.h */