mirror of
https://github.com/openvswitch/ovs
synced 2025-08-22 01:51:26 +00:00
0add983b38
Currently all OVSDB database queries except for UUID lookups all result in linear lookups over the entire table, even if an index is present. This patch modifies ovsdb_query() to attempt an index lookup first, if possible. If no matching indexes are present then a linear index is still conducted. To test this, I set up an ovsdb database with a variable number of rows and timed the average of how long ovsdb-client took to query a single row. The first two tests involved a linear scan that didn't match any rows, so there was no overhead associated with sending or encoding output. The post-patch linear scan was a worst case scenario where the table did have an appropriate index but the conditions made its usage impossible. The indexed lookup test was for a matching row, which did also include overhead associated with a match. The results are included in the table below. Rows | 100k | 200k | 300k | 400k | 500k -----------------------+------+------+------+------+----- Pre-patch linear scan | 9ms | 24ms | 37ms | 49ms | 61ms Post-patch linear scan | 9ms | 24ms | 38ms | 49ms | 61ms Indexed lookup | 3ms | 3ms | 3ms | 3ms | 3ms I also tested the performance of ovsdb_query() by wrapping it in a loop and measuring the time it took to perform 1000 linear scans on 1, 10, 100k, and 200k rows. This test showed that the new index checking code did not slow down worst case lookups to a statistically detectable degree. Reported-at: https://issues.redhat.com/browse/FDP-590 Signed-off-by: Mike Pattrick <mkp@redhat.com> Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
53 lines
1.9 KiB
C
53 lines
1.9 KiB
C
/*
|
|
* Copyright (c) 2017 Red Hat, Inc.
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at:
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
#ifndef OVSDB_RBAC_H
|
|
#define OVSDB_RBAC_H 1
|
|
|
|
#include <stdbool.h>
|
|
|
|
struct ovsdb;
|
|
struct ovsdb_column_set;
|
|
struct ovsdb_condition;
|
|
struct ovsdb_mutation_set;
|
|
struct ovsdb_row;
|
|
struct ovsdb_table;
|
|
struct ovsdb_txn;
|
|
|
|
bool ovsdb_rbac_insert(const struct ovsdb *,
|
|
const struct ovsdb_table *,
|
|
const struct ovsdb_row *,
|
|
const char *role, const char *id);
|
|
bool ovsdb_rbac_delete(const struct ovsdb *,
|
|
struct ovsdb_table *,
|
|
struct ovsdb_condition *,
|
|
const char *role, const char *id,
|
|
const struct ovsdb_txn *);
|
|
bool ovsdb_rbac_update(const struct ovsdb *,
|
|
struct ovsdb_table *,
|
|
struct ovsdb_column_set *,
|
|
struct ovsdb_condition *condition,
|
|
const char *role, const char *id,
|
|
const struct ovsdb_txn *);
|
|
bool ovsdb_rbac_mutate(const struct ovsdb *,
|
|
struct ovsdb_table *,
|
|
struct ovsdb_mutation_set *,
|
|
struct ovsdb_condition *,
|
|
const char *role, const char *id,
|
|
const struct ovsdb_txn *);
|
|
|
|
#endif /* ovsdb/rbac.h */
|