mirror of
https://github.com/openvswitch/ovs
synced 2025-08-23 10:28:00 +00:00
dd43a55859
I believe this is consistent with the handling of all other action parsing called from parse_named_action(). Verification of all actions, including learn actions, occurs separately in ofpact_check__(). It also occurs via in a call to ofpacts_check() in parse_ofp_str(), This patch is larger than might otherwise be expected as the flow argument of learn_parse() is now unused and thus removed. This propagates up the call-chain some way. This implementation was suggested by Jesse Gross in response to an enhancement I made to the validation performed during parsing learn actions to allow it to correctly account for changes to the dl_type due to MPLS push and pop actions. Tests have also been updated to check for the less specific messages generated by the call to ofpacts_check() in parse_ofp_str() which at the suggestion of Ben Pfaff was added by a prior patch for this purpose. Cc: Jesse Gross <jesse@nicira.com> Cc: Ben Pfaff <blp@nicira.com> Signed-off-by: Simon Horman <horms@verge.net.au> Signed-off-by: Ben Pfaff <blp@nicira.com>
46 lines
1.4 KiB
C
46 lines
1.4 KiB
C
/*
|
|
* Copyright (c) 2011, 2012 Nicira, Inc.
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at:
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
#ifndef LEARN_H
|
|
#define LEARN_H 1
|
|
|
|
#include "ofp-errors.h"
|
|
|
|
struct ds;
|
|
struct flow;
|
|
struct ofpbuf;
|
|
struct ofpact_learn;
|
|
struct ofputil_flow_mod;
|
|
struct nx_action_learn;
|
|
|
|
/* NXAST_LEARN helper functions.
|
|
*
|
|
* See include/openflow/nicira-ext.h for NXAST_LEARN specification.
|
|
*/
|
|
|
|
enum ofperr learn_from_openflow(const struct nx_action_learn *,
|
|
struct ofpbuf *ofpacts);
|
|
enum ofperr learn_check(const struct ofpact_learn *, const struct flow *);
|
|
void learn_to_nxast(const struct ofpact_learn *, struct ofpbuf *openflow);
|
|
|
|
void learn_execute(const struct ofpact_learn *, const struct flow *,
|
|
struct ofputil_flow_mod *, struct ofpbuf *ofpacts);
|
|
|
|
void learn_parse(char *, struct ofpbuf *ofpacts);
|
|
void learn_format(const struct ofpact_learn *, struct ds *);
|
|
|
|
#endif /* learn.h */
|