mirror of
https://github.com/openvswitch/ovs
synced 2025-08-22 09:58:01 +00:00
14347f3e82
At least on Linux, when process A connects to process B over a Unix domain socket, unless process A bound its socket to a name before it made the connection, process B gets an empty peer name. Until now, OVS has just reported the name of the connection as "unix". This is not meaningful, of course. I do not know of a good general solution to this problem, but this commit attempts a step in the right direction by at least giving each connection of this kind a number: "unix#1", "unix#2", and so on. That way, in log messages one can at least see which messages are related to a particular connection. Signed-off-by: Ben Pfaff <blp@ovn.org> Acked-by: Justin Pettit <jpettit@ovn.org>
139 lines
4.0 KiB
C
139 lines
4.0 KiB
C
/*
|
||
* Copyright (c) 2008, 2009, 2010, 2011, 2012, 2013, 2014, 2015 Nicira, Inc.
|
||
*
|
||
* Licensed under the Apache License, Version 2.0 (the "License");
|
||
* you may not use this file except in compliance with the License.
|
||
* You may obtain a copy of the License at:
|
||
*
|
||
* http://www.apache.org/licenses/LICENSE-2.0
|
||
*
|
||
* Unless required by applicable law or agreed to in writing, software
|
||
* distributed under the License is distributed on an "AS IS" BASIS,
|
||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||
* See the License for the specific language governing permissions and
|
||
* limitations under the License.
|
||
*/
|
||
|
||
#include <config.h>
|
||
#include "stream.h"
|
||
#include <errno.h>
|
||
#include <inttypes.h>
|
||
#include <netdb.h>
|
||
#include <poll.h>
|
||
#include <sys/socket.h>
|
||
#include <sys/types.h>
|
||
#include <sys/un.h>
|
||
#include <stdlib.h>
|
||
#include <string.h>
|
||
#include <unistd.h>
|
||
#include "ovs-atomic.h"
|
||
#include "packets.h"
|
||
#include "openvswitch/poll-loop.h"
|
||
#include "socket-util.h"
|
||
#include "dirs.h"
|
||
#include "util.h"
|
||
#include "stream-provider.h"
|
||
#include "stream-fd.h"
|
||
#include "openvswitch/vlog.h"
|
||
|
||
VLOG_DEFINE_THIS_MODULE(stream_unix);
|
||
|
||
/* Active UNIX socket. */
|
||
|
||
static int
|
||
unix_open(const char *name, char *suffix, struct stream **streamp,
|
||
uint8_t dscp OVS_UNUSED)
|
||
{
|
||
char *connect_path;
|
||
int fd;
|
||
|
||
connect_path = abs_file_name(ovs_rundir(), suffix);
|
||
fd = make_unix_socket(SOCK_STREAM, true, NULL, connect_path);
|
||
|
||
if (fd < 0) {
|
||
VLOG_DBG("%s: connection failed (%s)",
|
||
connect_path, ovs_strerror(-fd));
|
||
free(connect_path);
|
||
return -fd;
|
||
}
|
||
|
||
free(connect_path);
|
||
return new_fd_stream(xstrdup(name), fd, check_connection_completion(fd),
|
||
AF_UNIX, streamp);
|
||
}
|
||
|
||
const struct stream_class unix_stream_class = {
|
||
"unix", /* name */
|
||
false, /* needs_probes */
|
||
unix_open, /* open */
|
||
NULL, /* close */
|
||
NULL, /* connect */
|
||
NULL, /* recv */
|
||
NULL, /* send */
|
||
NULL, /* run */
|
||
NULL, /* run_wait */
|
||
NULL, /* wait */
|
||
};
|
||
|
||
/* Passive UNIX socket. */
|
||
|
||
static int punix_accept(int fd, const struct sockaddr_storage *ss,
|
||
size_t ss_len, struct stream **streamp);
|
||
|
||
static int
|
||
punix_open(const char *name OVS_UNUSED, char *suffix,
|
||
struct pstream **pstreamp, uint8_t dscp OVS_UNUSED)
|
||
{
|
||
char *bind_path;
|
||
int fd, error;
|
||
|
||
bind_path = abs_file_name(ovs_rundir(), suffix);
|
||
fd = make_unix_socket(SOCK_STREAM, true, bind_path, NULL);
|
||
if (fd < 0) {
|
||
VLOG_ERR("%s: binding failed: %s", bind_path, ovs_strerror(errno));
|
||
free(bind_path);
|
||
return errno;
|
||
}
|
||
|
||
if (listen(fd, 64) < 0) {
|
||
error = errno;
|
||
VLOG_ERR("%s: listen: %s", name, ovs_strerror(error));
|
||
close(fd);
|
||
free(bind_path);
|
||
return error;
|
||
}
|
||
|
||
return new_fd_pstream(xstrdup(name), fd,
|
||
punix_accept, bind_path, pstreamp);
|
||
}
|
||
|
||
static int
|
||
punix_accept(int fd, const struct sockaddr_storage *ss, size_t ss_len,
|
||
struct stream **streamp)
|
||
{
|
||
const struct sockaddr_un *sun = (const struct sockaddr_un *) ss;
|
||
int name_len = get_unix_name_len(sun, ss_len);
|
||
char *bound_name;
|
||
|
||
if (name_len > 0) {
|
||
bound_name = xasprintf("unix:%.*s", name_len, sun->sun_path);
|
||
} else {
|
||
/* When a Unix socket connects to us without first binding a name, we
|
||
* don't get any name for it. It's useful nevertheless to be able to
|
||
* distinguish separate sockets in log messages, so use a counter. */
|
||
static atomic_count next_idx = ATOMIC_COUNT_INIT(0);
|
||
bound_name = xasprintf("unix#%u", atomic_count_inc(&next_idx));
|
||
}
|
||
return new_fd_stream(bound_name, fd, 0, AF_UNIX, streamp);
|
||
}
|
||
|
||
const struct pstream_class punix_pstream_class = {
|
||
"punix",
|
||
false,
|
||
punix_open,
|
||
NULL,
|
||
NULL,
|
||
NULL,
|
||
};
|
||
|