mirror of
https://github.com/openvswitch/ovs
synced 2025-08-29 05:18:13 +00:00
e879d33e83
2012-09-14T05:38:26Z|00001|jsonrpc|WARN|tcp:127.0.0.1:6634: receive error: Con
ovsdb-client: transaction failed (Connection reset by peer)
NOTE: This occurs intermittently depending on how ovsdb-server runs.
Running ovsdb-client on a remote machine increases the possibility.
This is because ovsdb-server closes newly accepted tcp connection.
The following changesets caused it. struct jsonrpc_session::dscp isn't set
based on listening socket's dscp value.
- ovsdb-server creates passive connection and listens on it.
- ovsdb-server accepts connection by ovsdb_jsonrpc_server_run().
The accepted socket inherits from the listening sockets.
ovsdb_jsonrpc_server_run() creates json session, but leaves dscp of
struct jsonrpc_session zero.
- On calling reconfigure_from_db(), it resets dscp value to
all jsonrpc sessions. Eventually jsonrpc_session_set_dscp() is called.
Then jsonrpc_session_force_reconnect() closes the connection.
With this patch,
- struct jsonrpc_session::dscp is correctly set based on
listening sockets dscp value.
- dscp of listening socket is changed dynamically by setsockopt.
This leaves a window where accepted socket may have old dscp.
But it is ignored for now because it would complicates codes
too much.
The related change sets:
- 0442efd9b1a88d923b56eab6b72b6be8231a49f7
Reapplying the dscp changes: No need to restart DB/OVS on changing
dscp value.
- 59efa47adf3234ec51541405726d033173851285
Revert DSCP update changes.
- b2e18db292cd4962af3248f11e9f17e6eaf9c033
No need to restart DB / OVS on changing dscp value.
- f125905cdd3dc0339ad968c0a70128807884b400
Allow configuring DSCP on controller and manager connections.
Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>
Signed-off-by: Mehak Mahajan <mmahajan@nicira.com>
133 lines
5.1 KiB
C
133 lines
5.1 KiB
C
/*
|
||
* Copyright (c) 2009, 2010, 2012 Nicira, Inc.
|
||
*
|
||
* Licensed under the Apache License, Version 2.0 (the "License");
|
||
* you may not use this file except in compliance with the License.
|
||
* You may obtain a copy of the License at:
|
||
*
|
||
* http://www.apache.org/licenses/LICENSE-2.0
|
||
*
|
||
* Unless required by applicable law or agreed to in writing, software
|
||
* distributed under the License is distributed on an "AS IS" BASIS,
|
||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||
* See the License for the specific language governing permissions and
|
||
* limitations under the License.
|
||
*/
|
||
|
||
#ifndef JSONRPC_H
|
||
#define JSONRPC_H 1
|
||
|
||
/* This is an implementation of the JSON-RPC 1.0 specification defined at
|
||
* http://json-rpc.org/wiki/specification. */
|
||
|
||
#include <stdbool.h>
|
||
#include <stddef.h>
|
||
#include "openvswitch/types.h"
|
||
|
||
struct json;
|
||
struct jsonrpc_msg;
|
||
struct pstream;
|
||
struct reconnect_stats;
|
||
struct stream;
|
||
|
||
/* API for a JSON-RPC stream. */
|
||
|
||
/* Default port numbers.
|
||
*
|
||
* There is nothing standard about these port numbers. They are simply what
|
||
* we have chosen. */
|
||
#define JSONRPC_TCP_PORT 6632
|
||
#define JSONRPC_SSL_PORT 6632
|
||
|
||
int jsonrpc_stream_open(const char *name, struct stream **, uint8_t dscp);
|
||
int jsonrpc_pstream_open(const char *name, struct pstream **, uint8_t dscp);
|
||
|
||
struct jsonrpc *jsonrpc_open(struct stream *);
|
||
void jsonrpc_close(struct jsonrpc *);
|
||
|
||
void jsonrpc_run(struct jsonrpc *);
|
||
void jsonrpc_wait(struct jsonrpc *);
|
||
|
||
int jsonrpc_get_status(const struct jsonrpc *);
|
||
size_t jsonrpc_get_backlog(const struct jsonrpc *);
|
||
unsigned int jsonrpc_get_received_bytes(const struct jsonrpc *);
|
||
const char *jsonrpc_get_name(const struct jsonrpc *);
|
||
|
||
int jsonrpc_send(struct jsonrpc *, struct jsonrpc_msg *);
|
||
int jsonrpc_recv(struct jsonrpc *, struct jsonrpc_msg **);
|
||
void jsonrpc_recv_wait(struct jsonrpc *);
|
||
|
||
int jsonrpc_send_block(struct jsonrpc *, struct jsonrpc_msg *);
|
||
int jsonrpc_recv_block(struct jsonrpc *, struct jsonrpc_msg **);
|
||
int jsonrpc_transact_block(struct jsonrpc *, struct jsonrpc_msg *,
|
||
struct jsonrpc_msg **);
|
||
|
||
/* Messages. */
|
||
enum jsonrpc_msg_type {
|
||
JSONRPC_REQUEST, /* Request. */
|
||
JSONRPC_NOTIFY, /* Notification. */
|
||
JSONRPC_REPLY, /* Successful reply. */
|
||
JSONRPC_ERROR /* Error reply. */
|
||
};
|
||
|
||
struct jsonrpc_msg {
|
||
enum jsonrpc_msg_type type;
|
||
char *method; /* Request or notification only. */
|
||
struct json *params; /* Request or notification only. */
|
||
struct json *result; /* Successful reply only. */
|
||
struct json *error; /* Error reply only. */
|
||
struct json *id; /* Request or reply only. */
|
||
};
|
||
|
||
struct jsonrpc_msg *jsonrpc_create_request(const char *method,
|
||
struct json *params,
|
||
struct json **idp);
|
||
struct jsonrpc_msg *jsonrpc_create_notify(const char *method,
|
||
struct json *params);
|
||
struct jsonrpc_msg *jsonrpc_create_reply(struct json *result,
|
||
const struct json *id);
|
||
struct jsonrpc_msg *jsonrpc_create_error(struct json *error,
|
||
const struct json *id);
|
||
|
||
const char *jsonrpc_msg_type_to_string(enum jsonrpc_msg_type);
|
||
char *jsonrpc_msg_is_valid(const struct jsonrpc_msg *);
|
||
void jsonrpc_msg_destroy(struct jsonrpc_msg *);
|
||
|
||
char *jsonrpc_msg_from_json(struct json *, struct jsonrpc_msg **);
|
||
struct json *jsonrpc_msg_to_json(struct jsonrpc_msg *);
|
||
|
||
/* A JSON-RPC session with reconnection. */
|
||
|
||
struct jsonrpc_session *jsonrpc_session_open(const char *name);
|
||
struct jsonrpc_session *jsonrpc_session_open_unreliably(struct jsonrpc *,
|
||
uint8_t);
|
||
void jsonrpc_session_close(struct jsonrpc_session *);
|
||
|
||
void jsonrpc_session_run(struct jsonrpc_session *);
|
||
void jsonrpc_session_wait(struct jsonrpc_session *);
|
||
|
||
size_t jsonrpc_session_get_backlog(const struct jsonrpc_session *);
|
||
const char *jsonrpc_session_get_name(const struct jsonrpc_session *);
|
||
|
||
int jsonrpc_session_send(struct jsonrpc_session *, struct jsonrpc_msg *);
|
||
struct jsonrpc_msg *jsonrpc_session_recv(struct jsonrpc_session *);
|
||
void jsonrpc_session_recv_wait(struct jsonrpc_session *);
|
||
|
||
bool jsonrpc_session_is_alive(const struct jsonrpc_session *);
|
||
bool jsonrpc_session_is_connected(const struct jsonrpc_session *);
|
||
unsigned int jsonrpc_session_get_seqno(const struct jsonrpc_session *);
|
||
int jsonrpc_session_get_status(const struct jsonrpc_session *);
|
||
void jsonrpc_session_get_reconnect_stats(const struct jsonrpc_session *,
|
||
struct reconnect_stats *);
|
||
|
||
void jsonrpc_session_force_reconnect(struct jsonrpc_session *);
|
||
|
||
void jsonrpc_session_set_max_backoff(struct jsonrpc_session *,
|
||
int max_backofF);
|
||
void jsonrpc_session_set_probe_interval(struct jsonrpc_session *,
|
||
int probe_interval);
|
||
void jsonrpc_session_set_dscp(struct jsonrpc_session *,
|
||
uint8_t dscp);
|
||
|
||
#endif /* jsonrpc.h */
|