mirror of
https://github.com/openvswitch/ovs
synced 2025-08-22 01:51:26 +00:00
74ff3298c8
Define struct eth_addr and use it instead of a uint8_t array for all ethernet addresses in OVS userspace. The struct is always the right size, and it can be assigned without an explicit memcpy, which makes code more readable. "struct eth_addr" is a good type name for this as many utility functions are already named accordingly. struct eth_addr can be accessed as bytes as well as ovs_be16's, which makes the struct 16-bit aligned. All use seems to be 16-bit aligned, so some algorithms on the ethernet addresses can be made a bit more efficient making use of this fact. As the struct fits into a register (in 64-bit systems) we pass it by value when possible. This patch also changes the few uses of Linux specific ETH_ALEN to OVS's own ETH_ADDR_LEN, and removes the OFP_ETH_ALEN, as it is no longer needed. This work stemmed from a desire to make all struct flow members assignable for unrelated exploration purposes. However, I think this might be a nice code readability improvement by itself. Signed-off-by: Jarno Rajahalme <jrajahalme@nicira.com>
35 lines
1.1 KiB
C
35 lines
1.1 KiB
C
/* Copyright (c) 2009, 2010, 2011, 2012, 2013 Nicira, Inc.
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at:
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License. */
|
|
|
|
#ifndef OFPROTO_DPIF_MONITOR_H
|
|
#define OFPROTO_DPIF_MONITOR_H 1
|
|
|
|
#include <stdint.h>
|
|
|
|
#include "openflow/openflow.h"
|
|
#include "packets.h"
|
|
|
|
struct bfd;
|
|
struct cfm;
|
|
struct lldp;
|
|
struct ofport_dpif;
|
|
|
|
void ofproto_dpif_monitor_port_send_soon(const struct ofport_dpif *);
|
|
|
|
void ofproto_dpif_monitor_port_update(const struct ofport_dpif *,
|
|
struct bfd *, struct cfm *,
|
|
struct lldp *, const struct eth_addr *);
|
|
|
|
#endif /* ofproto-dpif-monitor.h */
|