postfix-3.10-20241113

postfix/HISTORY

@@ -28474,13 +28474,6 @@ Apologies for any names omitted.
 	authentication mechanism" now includes the name of that
 	mechanism. File: xsasl/xsasl_dovecot_server.c
 
-20241104
-
-	Logging: when a message transaction is canceled (i.e.
-	started but not completed), the cleanup server now logs
-	"queueid: canceled". This provides a clear signal to logfile
-	collation tools. File: cleanup/cleanup_api.c.
-
 20241028
 
 	Documentation: TLSRPT_README, section "Delivering TLSRPT
@@ -28497,3 +28490,20 @@ Apologies for any names omitted.
 	dict_pgsql_open() returned NULL when "hosts" specified a
 	non-URI target and "dbname" was not set. Instead, it should
 	return a surrogate dictionary. File: global/dict_pgsql.c.
+
+20241112
+
+	Logging: the cleanup server now logs "queueid: removed
+	(reason)" where "reason" is either "canceled" (message
+	transaction not completed) or "discarded" (DISCARD action
+	in access table, header/body_checks, or Milter response).
+
+20241113
+
+	Bugfix (defect introduced: Postfix 3.10, date 20240923):
+	TLSRPT support in tlsproxy dereferenced non-extent client
+	properties in the server role. Problem reported by Florian
+	Piekert. File: tlsproxy/tlsproxy.c
+
+	Cleanup: removed an unused string variable. File:
+	xsasl/xsasl_cyrus_server.c

postfix/WISHLIST

@@ -35,6 +35,9 @@ Wish list:
 
 	Add unit tests for smtp_tlsrpt.c, tlstrpd_wrapper.c, ...
 
+	Add sample master.cf entries for dovecot-lmtp and dovecot-pipe
+	with flags=DORX as appropriate, and single-recipient hints.
+
 	Add unit test for extpar.c
 
 	Add tests for Message-ID extraction in the cleanup daemon.

postfix/proto/stop.double-history

@@ -138,3 +138,4 @@ proto  proto mysql_table proto pgsql_table proto ldap_table
  local command c master master c master master h 
  pipe pipe c postfix postfix c postscreen postscreen_dnsbl c 
  qmgr qmgr_entry c qmqpd qmqpd_peer c smtp smtp h 
+ Piekert File tlsproxy tlsproxy c

postfix/proto/stop.spell-history

@@ -86,3 +86,4 @@ testfiles
 Antonin
 Verrier
 unescaped
+dereferenced

postfix/src/cleanup/cleanup_api.c

@@ -354,7 +354,8 @@ int     cleanup_flush(CLEANUP_STATE *state)
 	    (void) REMOVE(vstring_str(cleanup_trace_path));
 	if (REMOVE(cleanup_path))
 	    msg_warn("remove %s: %m", cleanup_path);
-	msg_info("%s: canceled", state->queue_id);
+	msg_info("%s: removed (%s)", state->queue_id, state->errs ?
+		 "canceled" : "discarded");
     }
 
     /*

postfix/src/global/mail_version.h

@@ -20,7 +20,7 @@
   * Patches change both the patchlevel and the release date. Snapshots have no
   * patchlevel; they change the release date only.
   */
-#define MAIL_RELEASE_DATE	"20241111"
+#define MAIL_RELEASE_DATE	"20241113"
 #define MAIL_VERSION_NUMBER	"3.10"
 
 #ifdef SNAPSHOT

postfix/src/tlsproxy/tlsproxy.c

@@ -738,9 +738,9 @@ static int tlsp_eval_tls_error(TLSP_STATE *state, int err)
 	 * already reported.
 	 */
 #ifdef USE_TLSRPT
-	if (state->client_start_props->tlsrpt
+	if (state->is_server_role == 0
 	    && (state->flags & TLSP_FLAG_DO_HANDSHAKE)
-	    && state->is_server_role == 0)
+	    && state->client_start_props->tlsrpt)
 	    trw_report_failure(state->client_start_props->tlsrpt,
 			       TLSRPT_VALIDATION_FAILURE,
 			        /* additional_info= */ (char *) 0,

postfix/src/xsasl/xsasl_cyrus_server.c

@@ -621,7 +621,6 @@ static int xsasl_cyrus_server_next(XSASL_SERVER *xp, const char *request,
 
 static const char *xsasl_cyrus_server_get_username(XSASL_SERVER *xp)
 {
-    const char *myname = "xsasl_cyrus_server_get_username";
     XSASL_CYRUS_SERVER *server = (XSASL_CYRUS_SERVER *) xp;
     VOID_SERVEROUT_TYPE serverout = 0;
     int     sasl_status;