mir/rtl88x2bu
2
0
Fork 0
mirror of https://github.com/cilynx/rtl88x2bu synced 2025-08-22 02:01:55 +00:00
Code Issues Projects Releases Wiki Activity

Replace to noop calls with comment

Browse Source 
Two calls in a function that had to be touched anyways were effectively
no-op on Linux. Thus, they are removed now. A comment explains why this
function with empty body exists.

Thanks at @CGarces for pointing this out.
This commit is contained in:
Max Görner 2022-08-25 21:31:55 +02:00
parent 95c81e43fa
commit fb0b1fd2c6
2 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
Makefile
View File

@ -2457,4 +2457,3 @@ clean:
rm -fr *.mod.c *.mod *.o .*.cmd *.ko *~ rm -fr *.mod.c *.mod *.o .*.cmd *.ko *~
rm -fr .tmp_versions *.ur-safe rm -fr .tmp_versions *.ur-safe
endif endif

10
core/rtw_sta_mgt.c
View File

@ -380,8 +380,13 @@ static void _rtw_free_sta_recv_priv_lock(struct sta_recv_priv *psta_recvpriv)
void rtw_mfree_stainfo(struct sta_info *psta); void rtw_mfree_stainfo(struct sta_info *psta);
void rtw_mfree_stainfo(struct sta_info *psta) void rtw_mfree_stainfo(struct sta_info *psta)
{ {
_rtw_free_sta_xmit_priv_lock(&psta->sta_xmitpriv); // Here used to be some calls to helper functions that would call
_rtw_free_sta_recv_priv_lock(&psta->sta_recvpriv); // _rtw_spinlock_free several times. However, _rtw_spinlock_free does not
// do anything on Linux. Since this project is concerned only with Linux,
// it is safe to remove the calls entirely.
// This function is kept. Removing it would force us to remove it in the
// callers, which has the danger of becoming incompatible with possible
// future patches.
} }
@ -1337,4 +1342,3 @@ void dump_pre_link_sta_ctl(void *sel, struct sta_priv *stapriv)
} }
} }
#endif /* CONFIG_RTW_PRE_LINK_STA */ #endif /* CONFIG_RTW_PRE_LINK_STA */