mir/sudo
2
0
Fork 0
mirror of https://github.com/sudo-project/sudo.git synced 2025-08-30 13:58:05 +00:00
Code Issues Releases Wiki Activity

Check for sysconf() negative return value instead of -1

Browse Source 
Quiets a coverity warning.
This commit is contained in:
Todd C. Miller
2025-01-14 12:51:28 -07:00
parent 405070d482
commit 0fdbb6e2ee
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
lib/util/setgroups.c
View File

@@ -1,7 +1,7 @@
/* /*
* SPDX-License-Identifier: ISC * SPDX-License-Identifier: ISC
* *
* Copyright (c) 2011-2012, 2014-2016 Todd C. Miller <Todd.Miller@sudo.ws> * Copyright (c) 2011-2012, 2014-2025 Todd C. Miller <Todd.Miller@sudo.ws>
* *
* Permission to use, copy, modify, and distribute this software for any * Permission to use, copy, modify, and distribute this software for any
* purpose with or without fee is hereby granted, provided that the above * purpose with or without fee is hereby granted, provided that the above
@@ -43,11 +43,12 @@ sudo_setgroups_v1(int ngids, const GETGROUPS_T *gids)
if (ngids < 0) if (ngids < 0)
debug_return_int(-1); debug_return_int(-1);
/* Linux uses size_t for ngids, BSD uses int. */
ret = setgroups(ngids, (GETGROUPS_T *)gids); ret = setgroups(ngids, (GETGROUPS_T *)gids);
if (ret == -1 && errno == EINVAL) { if (ret == -1 && errno == EINVAL) {
/* Too many groups, try again with fewer. */ /* Too many groups, try again with fewer. */
maxgids = sysconf(_SC_NGROUPS_MAX); maxgids = sysconf(_SC_NGROUPS_MAX);
if (maxgids == -1) if (maxgids < 0)
maxgids = NGROUPS_MAX; maxgids = NGROUPS_MAX;
if (ngids > maxgids) if (ngids > maxgids)
ret = setgroups((int)maxgids, (GETGROUPS_T *)gids); ret = setgroups((int)maxgids, (GETGROUPS_T *)gids);