mir/sudo
2
0
Fork 0
mirror of https://github.com/sudo-project/sudo.git synced 2025-08-22 09:57:41 +00:00
Code Issues Releases Wiki Activity

digest_matches: plug fd leak on snprinf() failure

Browse Source
This commit is contained in:
Todd C. Miller 2025-07-23 20:00:42 -06:00
parent 55d3c99c4e
commit 26a1a7529a
2 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
plugins/sudoers/match_command.c
View File

@ -272,7 +272,8 @@ command_matches_dir(struct sudoers_context *ctx, const char *sudoers_dir,
len = snprintf(sdbuf, sizeof(sdbuf), "%s%s", runchroot, sudoers_dir); len = snprintf(sdbuf, sizeof(sdbuf), "%s%s", runchroot, sudoers_dir);
if (len >= ssizeof(sdbuf)) { if (len >= ssizeof(sdbuf)) {
errno = ENAMETOOLONG; errno = ENAMETOOLONG;
debug_return_bool(false); sudo_warn("%s%s", runchroot, sudoers_dir);
goto done;
} }
sudoers_dir = sdbuf; sudoers_dir = sdbuf;
chrootlen = strlen(runchroot); chrootlen = strlen(runchroot);
@ -536,7 +537,8 @@ command_matches_glob(struct sudoers_context *ctx, const char *sudoers_cmnd,
snprintf(pathbuf, sizeof(pathbuf), "%s%s", runchroot, sudoers_cmnd); snprintf(pathbuf, sizeof(pathbuf), "%s%s", runchroot, sudoers_cmnd);
if (len >= ssizeof(pathbuf)) { if (len >= ssizeof(pathbuf)) {
errno = ENAMETOOLONG; errno = ENAMETOOLONG;
debug_return_bool(false); sudo_warn("%s%s", runchroot, sudoers_cmnd);
debug_return_int(DENY);
} }
sudoers_cmnd = pathbuf; sudoers_cmnd = pathbuf;
chrootlen = strlen(runchroot); chrootlen = strlen(runchroot);

3
plugins/sudoers/match_digest.c
View File

@ -73,7 +73,8 @@ digest_matches(int fd, const char *path, const char *runchroot,
snprintf(pathbuf, sizeof(pathbuf), "%s%s", runchroot, path); snprintf(pathbuf, sizeof(pathbuf), "%s%s", runchroot, path);
if (len >= ssizeof(pathbuf)) { if (len >= ssizeof(pathbuf)) {
errno = ENAMETOOLONG; errno = ENAMETOOLONG;
debug_return_bool(false); sudo_warn("%s%s", runchroot, path);
goto done;
} }
path = pathbuf; path = pathbuf;
} }