mir/sudo
2
0
Fork 0
mirror of https://github.com/sudo-project/sudo.git synced 2025-08-31 14:25:15 +00:00
Code Issues Releases Wiki Activity

In tty_present(), check for /dev/tty if sudo was unable to get the tty name.

Browse Source 
For requiretty it is enough to check that /dev/tty is available.
If sudo can't get the tty from the kernel (missing /proc?) that is OK.
This commit is contained in:
Todd C. Miller
2019-06-19 20:32:22 -06:00
parent 82920726fa
commit 29223d7f64
1 changed files with 8 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
plugins/sudoers/sudoers.c
View File

@@ -1272,12 +1272,13 @@ create_admin_success_flag(void)
static bool
tty_present(void)
{
#if defined(HAVE_KINFO_PROC2_NETBSD) || defined(HAVE_KINFO_PROC_OPENBSD) || defined(HAVE_KINFO_PROC_FREEBSD) || defined(HAVE_KINFO_PROC_44BSD) || defined(HAVE_STRUCT_PSINFO_PR_TTYDEV) || defined(HAVE_PSTAT_GETPROC) || defined(__linux__)
return user_ttypath != NULL;
#else
int fd = open(_PATH_TTY, O_RDWR);
if (fd != -1)
debug_decl(tty_present, SUDOERS_DEBUG_PLUGIN)
if (user_ttypath == NULL) {
int fd = open(_PATH_TTY, O_RDWR);
if (fd == -1)
debug_return_bool(false);
close(fd);
return fd != -1;
#endif
}
debug_return_bool(true);
}