Add regress test for symbol visibility.

MANIFEST

@@ -221,6 +221,7 @@ plugins/sudoers/po/zh_CN.po
 plugins/sudoers/pwutil.c
 plugins/sudoers/redblack.c
 plugins/sudoers/redblack.h
+plugins/sudoers/regress/check_symbols/check_symbols.c
 plugins/sudoers/regress/iolog_path/check_iolog_path.c
 plugins/sudoers/regress/iolog_path/data
 plugins/sudoers/regress/logging/check_wrap.c

plugins/sudoers/Makefile.in

@@ -112,7 +112,7 @@ SHELL = @SHELL@
 
 PROGS = sudoers.la visudo sudoreplay testsudoers
 
-TEST_PROGS = check_iolog_path check_fill check_wrap check_addr
+TEST_PROGS = check_iolog_path check_fill check_wrap check_addr check_symbols
 
 AUTH_OBJS = sudo_auth.lo @AUTH_OBJS@
 
@@ -139,6 +139,8 @@ CHECK_FILL_OBJS = check_fill.o toke_util.o error.o
 CHECK_IOLOG_PATH_OBJS = check_iolog_path.o error.o iolog_path.o pwutil.o \
 			redblack.o
 
+CHECK_SYMBOLS_OBJS = check_symbols.o error.o
+
 CHECK_WRAP_OBJS = check_wrap.o logwrap.o error.o
 
 LIBOBJDIR = $(top_builddir)/@ac_config_libobj_dir@/
@@ -188,6 +190,9 @@ check_iolog_path: $(CHECK_IOLOG_PATH_OBJS) $(LT_LIBS)
 check_fill: $(CHECK_FILL_OBJS) $(LT_LIBS)
 	$(LIBTOOL) --mode=link $(CC) -o $@ $(CHECK_FILL_OBJS) $(LDFLAGS) $(LIBS)
 
+check_symbols: $(CHECK_SYMBOLS_OBJS) $(LT_LIBS)
+	$(LIBTOOL) --mode=link $(CC) -o $@ $(CHECK_SYMBOLS_OBJS) $(LDFLAGS) $(LIBS)
+
 check_wrap: $(CHECK_WRAP_OBJS) $(LT_LIBS)
 	$(LIBTOOL) --mode=link $(CC) -o $@ $(CHECK_WRAP_OBJS) $(LDFLAGS) $(LIBS)
 
@@ -290,6 +295,10 @@ check: $(TEST_PROGS) visudo testsudoers
 	rval=`expr $$rval + $$?`; \
 	./check_iolog_path $(srcdir)/regress/iolog_path/data; \
 	rval=`expr $$rval + $$?`; \
+	if [ X"$(soext)" != X"" ]; then \
+	    ./check_symbols .libs/sudoers$(soext) $(symfile); \
+	    rval=`expr $$rval + $$?`; \
+	fi; \
 	./check_wrap $(srcdir)/regress/logging/check_wrap.in > check_wrap.out; \
 	diff check_wrap.out $(srcdir)/regress/logging/check_wrap.out.ok; \
 	rval=`expr $$rval + $$?`; \
@@ -448,6 +457,9 @@ check_iolog_path.o: $(srcdir)/regress/iolog_path/check_iolog_path.c \
                     $(incdir)/sudo_debug.h $(incdir)/gettext.h \
                     $(devdir)/def_data.c
 	$(CC) -c $(CPPFLAGS) $(CFLAGS) $(DEFS) $(srcdir)/regress/iolog_path/check_iolog_path.c
+check_symbols.o: $(srcdir)/regress/check_symbols/check_symbols.c $(top_builddir)/config.h \
+              $(incdir)/missing.h $(incdir)/error.h
+	$(CC) -c $(CPPFLAGS) $(CFLAGS) $(DEFS) $(srcdir)/regress/check_symbols/check_symbols.c
 check_wrap.o: $(srcdir)/regress/logging/check_wrap.c $(top_builddir)/config.h \
               $(incdir)/missing.h $(incdir)/error.h $(incdir)/sudo_plugin.h
 	$(CC) -c $(CPPFLAGS) $(CFLAGS) $(DEFS) $(srcdir)/regress/logging/check_wrap.c

plugins/sudoers/regress/check_symbols/check_symbols.c

@@ -0,0 +1,105 @@
+/*
+ * Copyright (c) 2012 Todd C. Miller <Todd.Miller@courtesan.com>
+ *
+ * Permission to use, copy, modify, and distribute this software for any
+ * purpose with or without fee is hereby granted, provided that the above
+ * copyright notice and this permission notice appear in all copies.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
+ * WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
+ * MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
+ * ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
+ * WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
+ * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
+ * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
+ */
+
+#include <config.h>
+
+#include <sys/types.h>
+#include <stdio.h>
+#ifdef STDC_HEADERS
+# include <stdlib.h>
+# include <stddef.h>
+#else
+# ifdef HAVE_STDLIB_H
+#  include <stdlib.h>
+# endif
+#endif /* STDC_HEADERS */
+#ifdef HAVE_STRING_H
+# if defined(HAVE_MEMORY_H) && !defined(STDC_HEADERS)
+#  include <memory.h>
+# endif
+# include <string.h>
+#endif /* HAVE_STRING_H */
+#ifdef HAVE_STRINGS_H
+# include <strings.h>
+#endif /* HAVE_STRINGS_H */
+#ifdef HAVE_DLOPEN
+# include <dlfcn.h>
+#else
+# include "compat/dlfcn.h"
+#endif
+#include <errno.h>
+#include <limits.h>
+
+#include "missing.h"
+#include "error.h"
+
+#ifndef LINE_MAX
+# define LINE_MAX 2048
+#endif
+
+static void
+usage(void)
+{
+    fprintf(stderr, "usage: load_symbols plugin.so symbols_file\n");
+    exit(1);
+}
+
+int
+main(int argc, char *argv[])
+{
+    void *handle, *sym;
+    const char *plugin_path;
+    const char *symbols_file;
+    char *cp, line[LINE_MAX];
+    FILE *fp;
+    int ntests = 0, errors = 0;
+
+    if (argc != 3)
+	usage();
+    plugin_path = argv[1];
+    symbols_file = argv[2];
+
+    handle = dlopen(plugin_path, RTLD_LAZY|RTLD_GLOBAL);
+    if (handle == NULL)
+	errorx2(1, "unable to dlopen %s: %s", plugin_path, dlerror());
+
+    fp = fopen(symbols_file, "r");
+    if (fp == NULL)
+	error2(1, "unable to open %s", symbols_file);
+
+    while (fgets(line, sizeof(line), fp) != NULL) {
+	ntests++;
+	if ((cp = strchr(line, '\n')) != NULL)
+	    *cp = '\0';
+	sym = dlsym(handle, line);
+	if (sym == NULL) {
+	    warningx2("unable to resolve symbol %s: %s", line, dlerror());
+	    errors++;
+	}
+    }
+    dlclose(handle);
+
+    printf("check_symbols: %d tests run, %d errors, %d%% success rate\n",
+	ntests, errors, (ntests - errors) * 100 / ntests);
+
+    exit(errors);
+}
+
+void
+cleanup(int gotsig)
+{
+    return;
+}